Fix macOS app packaging and related notes #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enables full resolution on Retina displays - Prevents app sleep (stalled prints?)
- Only upload the application, ie. exclude extraneous binary - Put the git commit hash in the app version metadata - Replace Mac OS X with macOS
kliment
reviewed
Jan 30, 2021
|
Oh, if someone could kindly help work out why the Windows build scripts stopped working, that would be appreciated! They were working in the commit before this PR, and I'm not really sure why they failed here since I don't see what the changes in this PR have to do with them... |
Problem was caused by inadvertent fancy quote characters in README
|
Never mind, I fixed it. My text editor substituted fancy quote characters in the README, and that caused problems when the README was read by |
Uses change suggested by @DivingDuck
|
Ok, I think this is ready to go if you have no more comments or concerns @kliment! |
|
Good to go in my opinion too. I'll merge it now. Thank you @a2k-hanlon and @DivingDuck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes to the github action script for the macOS build as well as some of the Printrun documentation pertaining to macOS. It's a follow up to #1117. The changes do the following:
Related to build for macOS:
.specfile in the repository, since @kliment wanted to avoid doing sobuildinstructions.txtpreviouslyRelated to documentation:
spctlto get the app to run. I don't think that's necessary, nor is it a good idea for security reasons.