Devel #11
Open
Devel #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmantel
force-pushed
the
devel
branch
2 times, most recently
from
2c24a30 to
afc383c
Compare
kmantel
force-pushed
the
devel
branch
2 times, most recently
from
d3853b8 to
a5e16b6
Compare
kmantel
force-pushed
the
devel
branch
2 times, most recently
from
e98b008 to
a61bd8c
Compare
kmantel
force-pushed
the
devel
branch
3 times, most recently
from
71fef65 to
1cd1f8a
Compare
kmantel
force-pushed
the
devel
branch
5 times, most recently
from
ebf8991 to
441c366
Compare
kmantel
force-pushed
the
devel
branch
4 times, most recently
from
7aff047 to
8129909
Compare
kmantel
force-pushed
the
devel
branch
2 times, most recently
from
b29e7ef to
4fe86af
Compare
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
…niversity#2856) Include all constructor attributes, not just conditions: - default_execution_id - mode - default_absolute_time_unit For example, setting of Scheduler.mode using argument scheduling_mode to Composition.run would not persist across Scheduler rebuilds.
* requirements: update beartype requirement from <0.15.0 to <0.16.0 (PrincetonUniversity#2744) * Fix/input port combine (PrincetonUniversity#2755) • inputport.py _parse_port_specific_specs(): fix bug in which COMBINE was not parsed when specified in an InputPort specification dict (though still some weirdness in passing spec through to constructor, requiring function assignment in place) • port.py _parse_port_spec(): add passing of Context.string for local handling based on caller (e.g., warning messages) * Feat/em composition refactor learning mech (PrincetonUniversity#2754) • EMstoragemechanism.py - refactor memory_matrix to use learning_signals • emcomposition.py - refactor to use memory_matrix of storage_node if that is implemented Co-authored-by: jdcpni <pniintel55> * requirements: update dill requirement from <0.3.7 to <0.3.8 (PrincetonUniversity#2743) * tests/ParameterEstimationComposition: Provide expected result instead of relying on tolerance Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu> * tests/ParameterEstimationComposition: Reduce the number of estimates by 40x It's still enough to recover the parameters and reduces test time significantly. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu> --------- Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jdcpni <jdc@princeton.edu> Co-authored-by: Jan Vesely <jan.vesely@rutgers.edu>
Resolve all differences in favor of devel. master changes are stale because they mirror old commits on devel. * master: tests/ParameterEstimationComposition: Reduce the number of estimates by 40x tests/ParameterEstimationComposition: Provide expected result instead of relying on tolerance requirements: update dill requirement from <0.3.7 to <0.3.8 (PrincetonUniversity#2743) Feat/em composition refactor learning mech (PrincetonUniversity#2754) Fix/input port combine (PrincetonUniversity#2755) requirements: update beartype requirement from <0.15.0 to <0.16.0 (PrincetonUniversity#2744)
Merge master into devel
- dependency dict must store names, not classes - must exclude own class name from dependencies (but not "alias" class names like And->All or Or->Any
supports graph structure conditions automatically
function that produces a python sorting key given a dependency dictionary
- modify Scheduler wrappers to support both basic and structural Conditions - add wrappers for new graph_scheduler.Scheduler methods: - remove_condition - add_graph_edge - remove_graph_edge - update requirements to graph-scheduler<1.3.0 to include graph structure conditions release
…onditions Support graph-scheduler graph structure conditions
overriding _initialize_parameters lets UDF custom Parameters use all existing code for parsing/setting/etc. just like normal Parameters
- do not run logging.basicConfig - allow specifying level with environment variable PNL_LOGGING (logging level, 1=DEBUG, 0=disabled) - add global functions set_python_log_level and disable_python_logging
WeakKeyDictionary stores weak references to its keys, but throws a TypeError and does not dereference a weakref proxy/ref even if the proxied object is the same as one of its keys
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action