Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest injector version/repo #35

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Use latest injector version/repo #35

merged 3 commits into from
Jul 25, 2024

Conversation

russkel
Copy link
Contributor

@russkel russkel commented Jul 25, 2024

I was able to get this passing tests on Linux. Other platforms I am unable to test.

@kmaork
Copy link
Owner

kmaork commented Jul 25, 2024

Thanks for the contribution!
I fixed the CI on master and updated your branch from master.
To fix the CI in your branch you need to add .S files to the MANIFEST.in.
BTW, is there any specific reason you wanted to update the injector version?

@russkel
Copy link
Contributor Author

russkel commented Jul 25, 2024

Thanks for the contribution! I fixed the CI on master and updated your branch from master. To fix the CI in your branch you need to add .S files to the MANIFEST.in. BTW, is there any specific reason you wanted to update the injector version?

My pleasure. I have done this.

No specific reason no, just to get bug fixes etc. Also being the same version as trunk makes it easier to get support if I need to. I have some patches to hypno on the way and I thought if I was doing that I may as well update to the latest version.

@kmaork
Copy link
Owner

kmaork commented Jul 25, 2024

Great, thanks!

@kmaork kmaork merged commit ca2a0d1 into kmaork:master Jul 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants