Fix crash on ad fail (#66)

kmcgill88 · Sep 14, 2019 · 6156046 · 6156046
1 parent 4f8a968
commit 6156046
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 5 deletions.
diff --git a/.gitignore b/.gitignore
@@ -7,3 +7,4 @@ pubspec.lock
 
 build/
 .idea
+example/ios/Flutter/flutter_export_environment.sh
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
+## [0.3.2] - 2019/09/11
+iOS Interstitial crash fix if `didFailToReceiveAdWithError`
+
 ## [0.3.1] - 2019/05/31
-iOS Banner Crash fix
+iOS Banner crash fix
 
 ## [0.3.0] - 2019/05/28
 Add iOS support!

diff --git a/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme b/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1020"
+   LastUpgradeVersion = "1030"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/ios/Classes/AdmobInterstitialPlugin.swift b/ios/Classes/AdmobInterstitialPlugin.swift
@@ -131,7 +131,10 @@ class AdmobIntersitialPluginDelegate: NSObject, GADInterstitialDelegate {
     }
 
     func interstitial(_ ad: GADInterstitial, didFailToReceiveAdWithError error: GADRequestError) {
-        channel.invokeMethod("failedToLoad", arguments: ["errorCode": error])
+        channel.invokeMethod("failedToLoad", arguments:  [
+            "errorCode": error.code,
+            "error": error.localizedDescription
+        ])
     }
 
     func interstitialDidFail(toPresentScreen ad: GADInterstitial) {

diff --git a/ios/admob_flutter.podspec b/ios/admob_flutter.podspec
@@ -3,7 +3,7 @@
 #
 Pod::Spec.new do |s|
   s.name             = 'admob_flutter'
-  s.version          = '0.3.1'
+  s.version          = '0.3.2'
   s.swift_version    = '5.0'
   s.summary          = 'Admob plugin that shows banner ads using native platform views.'
   s.description      = <<-DESC

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: admob_flutter
 description: Admob plugin that shows banner ads using native platform views.
-version: 0.3.1
+version: 0.3.2
 author: Youssef Kababe <youssef.kbe@gmail.com>
 homepage: https://github.com/YoussefKababe/admob_flutter
Original file line number	Diff line number	Diff line change
Expand Up		@@ -7,3 +7,4 @@ pubspec.lock

		build/
		.idea
		example/ios/Flutter/flutter_export_environment.sh