Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some Banner ads view issues... #114

Open
brahim-aznag opened this issue Dec 17, 2019 · 3 comments
Open

some Banner ads view issues... #114

brahim-aznag opened this issue Dec 17, 2019 · 3 comments
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@brahim-aznag
Copy link

First of all, Thanks for your efforts & time to make this awesome package exist, But I hit some issues along the way like :

  1. The 'AdView' keeps refreshing itself every time the user clicked on button even the button has simple functionality that doesn't change all the UI like "save something...or add to a favorite..." and that makes the 'AdView' refreshing itself every time.
    ---> And I think this is a bad user experience...
  2. Sometimes ads just won't show and keeps there places in the UI.
    ---> And again, I think this is a bad user experience...
  3. I hope to see the package supports native ads too...
  4. I hope to see the keywords property and tested device added in the future to this beautiful package.
    Finally, thanks again for your efforts and time to make this beautiful package. :)
@brahim-aznag brahim-aznag changed the title Banner ads some Banner ads view issues... Dec 17, 2019
@kmcgill88
Copy link
Owner

@designerbrahim thanks for the kind words. @YoussefKababe started this project. I only added iOS support. 😄

  1. A lot of people have had this experience too. I believe it's the way the plugin creates a new ad every time flutter re-renders. One fix to this is to lift the banner up to the very top of your widget tree in a stateful widget so it isn't re-rendered.
  2. I agree this isn't a great UX. It would be nice to have a callback to notify flutter so a dev could take action. ie. Hide the widget until it is loaded. We will have to add to the road map.
  3. Native Ads would be a great item to put on this project's road map. flutter_native_ads might work in the man time.
  4. This is a top priority to get in. There are currently 2 PR's open attempting to solve this. I'm collecting feedback and determining what would be the easiest API to accomplish this. Stay tuned!

Speaking of road maps. This project doesn't officially have one! 😂 I'll get one started in the project board.

@kmcgill88 kmcgill88 added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Dec 17, 2019
@brahim-aznag
Copy link
Author

Thanks @kmcgill88 for this clarity.
ah.., almost forgot, thanks to @YoussefKababe also and his efforts on the android side.
We hope to see the package grows and gets stronger... in the future.
💪💪

@trqalothman
Copy link

Thanks to @kmcgill88 and @YoussefKababe , this is a great package.

Can you please make it so that we can use "const" and prevent ad refresh on every state change!

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants