Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ads from being reloaded #129

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

brnostone
Copy link
Contributor

Prevent refreshing of the banner when calling setState / Navigator push()/pop()
Fixes #18 #61 #114

Copy link
Owner

@kmcgill88 kmcgill88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've heart const helps prevent rerenders. Could you please help me understand why/how? Or point me in the direction of some docs.

Thanks!

@brnostone
Copy link
Contributor Author

The problem is in the use of the key, which was causing the reference to be lost.

https://www.youtube.com/watch?v=kn0EOS-ZiIc

@kmcgill88 kmcgill88 merged commit 97b0000 into kmcgill88:master Feb 10, 2020
@benevolent13
Copy link

Still facing the reload issue with version 1.0.0-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Banner is re-created/re-loaded with each Navigator push()/pop()
3 participants