Banner is re-created/re-loaded with each Navigator push()/pop() #18

kestasb · 2019-02-16T22:41:01Z

Banner is reloaded with each Navigator push()/pop(), both onBannerCreated and AdmobAdEvent.loaded are called even the banner is a child of a const StalessWidget, whose build() method isn't called.
Admob guidelines does not recommend to refresh banner manually.
Is it possible to avoid this behaviour?

inartin · 2019-04-18T07:42:51Z

Have you found any solutions to that ? I have the same problem.
Also most of the time I don't see any ads at all, I thing that's because it is rebuilded on every move, scroll ...

--Update
Just updated to 0.2.0 and now ads are shown as expected :)

mmahkamov · 2019-05-30T17:36:46Z

I was having a similar issue when the AdmobBanner widget was used in a ListView.

I wrapped AdmobBanner into a custom AdmobBannerWrapper stateful widget with AutomaticKeepAliveClientMixin - the issue was resolved.

mmahkamov · 2019-05-30T17:39:48Z

I think the AdmobBanner widget should be implemented with AutomaticKeepAliveClientMixin out of the box because redundant reloading of banners should be avoided (because it generates false impressions?). One could optionally pass the value for the wantKeepAlive property in the constructor.

sumitgohil · 2019-06-26T16:55:56Z

@mmahkamov Can you help me out? How should be this Implemented? How did you resolve the issue?

mmahkamov · 2019-06-27T10:29:14Z

@mmahkamov Can you help me out? How should be this Implemented? How did you resolve the issue?

I've just wrapped AdmobBanner inside a stateful widget which implements AutomaticKeepAliveClientMixin:

class AdmobBannerWrapper extends StatefulWidget {
  final String adUnitId;
  final AdmobBannerSize adSize;

  AdmobBannerWrapper({
    Key key,
    this.adUnitId, this.adSize
  }) : super(key: key);

  @override
  AdmobBannerWrapperState createState() => AdmobBannerWrapperState();
}

class AdmobBannerWrapperState extends State<AdmobBannerWrapper> with AutomaticKeepAliveClientMixin {
  bool get wantKeepAlive => true;

  @override
  Widget build(BuildContext context) {
    return AdmobBanner(
            adUnitId: widget.adUnitId, 
            adSize: widget.adSize
    );
  }
}

sumitgohil · 2019-06-27T11:42:57Z

@mmahkamov Looks like this doesn't work for me. The Banner ad still keeps reloading while popping view.

kyleorin · 2019-06-27T11:53:28Z

@mmahkamov I tried your method above, it seems the reloading doesn't stop although a new error appeared:

<Google> Cannot find an ad network adapter with the name(s): com.google.DummyAdapter. Remember to link all required ad network adapters and SDKs, and set -ObjC in the 'Other Linker Flags' setting of your build target.

(using the test banner ad)

also, I called the widget like so:

AdmobBannerWrapper(
                  adUnitId: 'ca-app-pub-3940256099942544/2934735716',
                  adSize: AdmobBannerSize.BANNER,
                ),

mmahkamov · 2019-06-28T08:54:42Z

@mmahkamov Looks like this doesn't work for me. The Banner ad still keeps reloading while popping view.

Are you using FutureBuilder by any chance?

narayanansampath · 2019-09-27T16:37:59Z

@mmahkamov Can you help me out? How should be this Implemented? How did you resolve the issue?

I've just wrapped AdmobBanner inside a stateful widget which implements AutomaticKeepAliveClientMixin:

class AdmobBannerWrapper extends StatefulWidget {
  final String adUnitId;
  final AdmobBannerSize adSize;

  AdmobBannerWrapper({
    Key key,
    this.adUnitId, this.adSize
  }) : super(key: key);

  @override
  AdmobBannerWrapperState createState() => AdmobBannerWrapperState();
}

class AdmobBannerWrapperState extends State<AdmobBannerWrapper> with AutomaticKeepAliveClientMixin {
  bool get wantKeepAlive => true;

  @override
  Widget build(BuildContext context) {
    return AdmobBanner(
            adUnitId: widget.adUnitId, 
            adSize: widget.adSize
    );
  }
}

This fix didn't work for me and I'm not using FutureBuilder too. Please help :(

nimish1995 · 2019-09-29T10:29:10Z

no working! Any solution? in every refresh of the list it shows blank blink which not looks good. and is there any way to preload the banner and show only if it's loaded??

mmahkamov · 2019-09-29T10:37:52Z

The blink is happening because the background color of the native widget is white by default. You need to patch the native side to make the host view transparent.

nimish1995 · 2019-09-29T10:39:41Z

The blink is happening because the background color of the native widget is white by default. You need to patch the native side to make the host view transparent.

Can you share the code? How can do that?

narayanansampath · 2019-09-29T11:09:57Z

The blink is happening because the background color of the native widget is white by default. You need to patch the native side to make the host view transparent.

I changed the container color to white as my screen background is white but the ad container still displays black color.

nimish1995 · 2019-09-29T11:27:33Z

The blink is happening because the background color of the native widget is white by default. You need to patch the native side to make the host view transparent.

I changed the container color to white as my screen background is white but the ad container still displays black color.

same here

mmahkamov · 2019-10-01T11:52:55Z

The blink is happening because the background color of the native widget is white by default. You need to patch the native side to make the host view transparent.

Can you share the code? How can do that?

You can get the idea from the following patch or just git apply it.

From 7a8e1be7ae027626fc77db41386595268707119f Mon Sep 17 00:00:00 2001
From: Muzaffar Mahkamov <muzaffar@mahkamov.com>
Date: Sun, 30 Jun 2019 12:01:49 +0500
Subject: [PATCH] * making AdmobBanner background transparent

---
 .../com/shatsy/admobflutter/AdmobBanner.kt    |  1 +
 .../shatsy/admobflutter/TransparentView.kt    | 25 +++++++++++++++++++
 2 files changed, 26 insertions(+)
 create mode 100644 android/src/main/kotlin/com/shatsy/admobflutter/TransparentView.kt

diff --git a/android/src/main/kotlin/com/shatsy/admobflutter/AdmobBanner.kt b/android/src/main/kotlin/com/shatsy/admobflutter/AdmobBanner.kt
index 7319607..8077f89 100644
--- a/android/src/main/kotlin/com/shatsy/admobflutter/AdmobBanner.kt
+++ b/android/src/main/kotlin/com/shatsy/admobflutter/AdmobBanner.kt
@@ -44,6 +44,7 @@ class AdmobBanner(context: Context, messenger: BinaryMessenger, id: Int, args: H
   }
 
   override fun getView(): View {
+    adView.makeWindowTransparent()
     return adView
   }
 
diff --git a/android/src/main/kotlin/com/shatsy/admobflutter/TransparentView.kt b/android/src/main/kotlin/com/shatsy/admobflutter/TransparentView.kt
new file mode 100644
index 0000000..0842c10
--- /dev/null
+++ b/android/src/main/kotlin/com/shatsy/admobflutter/TransparentView.kt
@@ -0,0 +1,25 @@
+package com.shatsy.admobflutter
+
+import android.view.View
+import android.view.Window
+import android.graphics.Color
+import android.graphics.drawable.ColorDrawable
+
+public fun View.makeWindowTransparent() {
+  this.post {
+    try {
+      var parent = this.parent ?: return@post
+      while (parent?.parent != null) {
+        parent = parent.parent
+      }
+      val decorView = parent.javaClass.getDeclaredMethod("getView").invoke(parent)
+      val windowField = decorView.javaClass.getDeclaredField("mWindow")
+      windowField.isAccessible = true
+      val window = windowField.get(decorView) as Window
+      windowField.isAccessible = false
+      window.setBackgroundDrawable(ColorDrawable(Color.TRANSPARENT))
+    } catch (e: Exception) {
+      // log it
+    }
+  }
+}
\ No newline at end of file
-- 
2.20.1

narayanansampath · 2019-10-01T14:41:47Z

The blink is happening because the background color of the native widget is white by default. You need to patch the native side to make the host view transparent.

Can you share the code? How can do that?

You can get the idea from the following patch or just git apply it.

From 7a8e1be7ae027626fc77db41386595268707119f Mon Sep 17 00:00:00 2001
From: Muzaffar Mahkamov <muzaffar@mahkamov.com>
Date: Sun, 30 Jun 2019 12:01:49 +0500
Subject: [PATCH] * making AdmobBanner background transparent

---
 .../com/shatsy/admobflutter/AdmobBanner.kt    |  1 +
 .../shatsy/admobflutter/TransparentView.kt    | 25 +++++++++++++++++++
 2 files changed, 26 insertions(+)
 create mode 100644 android/src/main/kotlin/com/shatsy/admobflutter/TransparentView.kt

diff --git a/android/src/main/kotlin/com/shatsy/admobflutter/AdmobBanner.kt b/android/src/main/kotlin/com/shatsy/admobflutter/AdmobBanner.kt
index 7319607..8077f89 100644
--- a/android/src/main/kotlin/com/shatsy/admobflutter/AdmobBanner.kt
+++ b/android/src/main/kotlin/com/shatsy/admobflutter/AdmobBanner.kt
@@ -44,6 +44,7 @@ class AdmobBanner(context: Context, messenger: BinaryMessenger, id: Int, args: H
   }
 
   override fun getView(): View {
+    adView.makeWindowTransparent()
     return adView
   }
 
diff --git a/android/src/main/kotlin/com/shatsy/admobflutter/TransparentView.kt b/android/src/main/kotlin/com/shatsy/admobflutter/TransparentView.kt
new file mode 100644
index 0000000..0842c10
--- /dev/null
+++ b/android/src/main/kotlin/com/shatsy/admobflutter/TransparentView.kt
@@ -0,0 +1,25 @@
+package com.shatsy.admobflutter
+
+import android.view.View
+import android.view.Window
+import android.graphics.Color
+import android.graphics.drawable.ColorDrawable
+
+public fun View.makeWindowTransparent() {
+  this.post {
+    try {
+      var parent = this.parent ?: return@post
+      while (parent?.parent != null) {
+        parent = parent.parent
+      }
+      val decorView = parent.javaClass.getDeclaredMethod("getView").invoke(parent)
+      val windowField = decorView.javaClass.getDeclaredField("mWindow")
+      windowField.isAccessible = true
+      val window = windowField.get(decorView) as Window
+      windowField.isAccessible = false
+      window.setBackgroundDrawable(ColorDrawable(Color.TRANSPARENT))
+    } catch (e: Exception) {
+      // log it
+    }
+  }
+}
\ No newline at end of file
-- 
2.20.1

Can you please elaborate on the steps for applying this as patch. Thanks.

oliverbytes · 2019-10-19T02:25:24Z

The blink is happening because the background color of the native widget is white by default. You need to patch the native side to make the host view transparent.

Can you share the code? How can do that?

You can get the idea from the following patch or just git apply it.

From 7a8e1be7ae027626fc77db41386595268707119f Mon Sep 17 00:00:00 2001
From: Muzaffar Mahkamov <muzaffar@mahkamov.com>
Date: Sun, 30 Jun 2019 12:01:49 +0500
Subject: [PATCH] * making AdmobBanner background transparent

---
 .../com/shatsy/admobflutter/AdmobBanner.kt    |  1 +
 .../shatsy/admobflutter/TransparentView.kt    | 25 +++++++++++++++++++
 2 files changed, 26 insertions(+)
 create mode 100644 android/src/main/kotlin/com/shatsy/admobflutter/TransparentView.kt

diff --git a/android/src/main/kotlin/com/shatsy/admobflutter/AdmobBanner.kt b/android/src/main/kotlin/com/shatsy/admobflutter/AdmobBanner.kt
index 7319607..8077f89 100644
--- a/android/src/main/kotlin/com/shatsy/admobflutter/AdmobBanner.kt
+++ b/android/src/main/kotlin/com/shatsy/admobflutter/AdmobBanner.kt
@@ -44,6 +44,7 @@ class AdmobBanner(context: Context, messenger: BinaryMessenger, id: Int, args: H
   }
 
   override fun getView(): View {
+    adView.makeWindowTransparent()
     return adView
   }
 
diff --git a/android/src/main/kotlin/com/shatsy/admobflutter/TransparentView.kt b/android/src/main/kotlin/com/shatsy/admobflutter/TransparentView.kt
new file mode 100644
index 0000000..0842c10
--- /dev/null
+++ b/android/src/main/kotlin/com/shatsy/admobflutter/TransparentView.kt
@@ -0,0 +1,25 @@
+package com.shatsy.admobflutter
+
+import android.view.View
+import android.view.Window
+import android.graphics.Color
+import android.graphics.drawable.ColorDrawable
+
+public fun View.makeWindowTransparent() {
+  this.post {
+    try {
+      var parent = this.parent ?: return@post
+      while (parent?.parent != null) {
+        parent = parent.parent
+      }
+      val decorView = parent.javaClass.getDeclaredMethod("getView").invoke(parent)
+      val windowField = decorView.javaClass.getDeclaredField("mWindow")
+      windowField.isAccessible = true
+      val window = windowField.get(decorView) as Window
+      windowField.isAccessible = false
+      window.setBackgroundDrawable(ColorDrawable(Color.TRANSPARENT))
+    } catch (e: Exception) {
+      // log it
+    }
+  }
+}
\ No newline at end of file
-- 
2.20.1

Can you please elaborate on the steps for applying this as patch. Thanks.

I second this. please help us bro... thanks a lot

kmcgill88 · 2019-10-19T04:26:18Z

Has anyone in this thread considered doing something like this? #61 (comment)

oliverbytes · 2019-11-01T22:42:19Z

#61 (comment)

That is a nice workaround. But I'd rather use firebase_admob for that.

edeuss · 2019-12-19T11:16:40Z

@kestasb Where you able to get a work around for this issue?

trqalothman · 2020-01-30T13:17:57Z

Any update/fix for this issue? it is one thing that is holding me back from the new release :(

benevolent13 · 2020-02-24T10:25:25Z

I was having a similar issue when the AdmobBanner widget was used in a ListView.

I wrapped AdmobBanner into a custom AdmobBannerWrapper stateful widget with AutomaticKeepAliveClientMixin - the issue was resolved.

Doesn't work for me.It gets reloaded everytime setState is called. :(

erperejildo · 2020-02-26T15:48:13Z

class AdmobBannerWrapper extends StatefulWidget {
final String adUnitId;
final AdmobBannerSize adSize;

AdmobBannerWrapper({
Key key,
this.adUnitId, this.adSize
}) : super(key: key);

@OverRide
AdmobBannerWrapperState createState() => AdmobBannerWrapperState();
}

class AdmobBannerWrapperState extends State with AutomaticKeepAliveClientMixin {
bool get wantKeepAlive => true;

@OverRide
Widget build(BuildContext context) {
return AdmobBanner(
adUnitId: widget.adUnitId,
adSize: widget.adSize
);
}
}

this didn't work for me

erperejildo · 2020-02-26T15:52:04Z

This quite important error has more than a year now

sumitgohil · 2020-02-26T17:07:51Z

I am not sure if I've made a solution to this, but it kinda worked for me. I made changed to this long back and I don't really have a track on them. I've also changed channel names and it's done on fork of a previous version of this lib. It might not contain features available in the newer version. I've added this to my repo. If someone could check and see if this works.

https://github.com/sumitgohil/flutter_admob_plugin

edeuss · 2020-02-27T02:37:00Z

@sumitgohil @erperejildo It is in the package but hasn't been updated in the pub.dev

Use this for now:

admob_flutter:
    git:
      url: git://github.com/kmcgill88/admob_flutter.git

erperejildo · 2020-02-27T11:44:11Z

@sumitgohil @erperejildo It is in the package but hasn't been updated in the pub.dev

Use this for now:
admob_flutter:
    git:
      url: git://github.com/kmcgill88/admob_flutter.git

I can confirm this, it works.

Let's see when this gets merged

kmcgill88 added enhancement New feature or request help wanted Extra attention is needed more info required An issue was created with enough information to debug. labels May 23, 2019

kyleorin mentioned this issue Jun 20, 2019

Android - Ad refusing to load | iOS - Ad freezes app #45

Open

kyleorin mentioned this issue Jun 27, 2019

Adding ad in iOS device calling build method continuously. #42

Open

abinmittu mentioned this issue Jul 23, 2019

Getting this error when moving from one screen to another #58

Open

abhijeet971992 mentioned this issue Jan 7, 2020

Execution failed for task ':admob_flutter:compileDebugKotlin' #120

Open

brnostone mentioned this issue Feb 10, 2020

Prevent ads from being reloaded #129

Merged

kmcgill88 closed this as completed in #129 Feb 10, 2020

machkonti mentioned this issue Feb 11, 2020

example code implementation error #131

Open

hygehyge mentioned this issue May 28, 2020

(Android) Unhandled Exception: MissingPluginException(No implementation found for method dispose on channel admob_flutter/banner_0)) #172

Closed

camposFabio mentioned this issue Jul 7, 2020

(Android) Unhandled Exception: MissingPluginException(No implementation found for method initialize on channel admob_flutter) #72

Open

willladislaw mentioned this issue Jan 12, 2021

env: sh\r: No such file or directory #251

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Banner is re-created/re-loaded with each Navigator push()/pop() #18

Banner is re-created/re-loaded with each Navigator push()/pop() #18

kestasb commented Feb 16, 2019

inartin commented Apr 18, 2019 •

edited

Loading

mmahkamov commented May 30, 2019

mmahkamov commented May 30, 2019 •

edited

Loading

sumitgohil commented Jun 26, 2019

mmahkamov commented Jun 27, 2019

sumitgohil commented Jun 27, 2019

kyleorin commented Jun 27, 2019

mmahkamov commented Jun 28, 2019

narayanansampath commented Sep 27, 2019

nimish1995 commented Sep 29, 2019

mmahkamov commented Sep 29, 2019

nimish1995 commented Sep 29, 2019

narayanansampath commented Sep 29, 2019

nimish1995 commented Sep 29, 2019

mmahkamov commented Oct 1, 2019

narayanansampath commented Oct 1, 2019

oliverbytes commented Oct 19, 2019

kmcgill88 commented Oct 19, 2019

oliverbytes commented Nov 1, 2019

edeuss commented Dec 19, 2019

trqalothman commented Jan 30, 2020

benevolent13 commented Feb 24, 2020

erperejildo commented Feb 26, 2020

erperejildo commented Feb 26, 2020

sumitgohil commented Feb 26, 2020 •

edited

Loading

edeuss commented Feb 27, 2020

erperejildo commented Feb 27, 2020

Banner is re-created/re-loaded with each Navigator push()/pop() #18

Banner is re-created/re-loaded with each Navigator push()/pop() #18

Comments

kestasb commented Feb 16, 2019

inartin commented Apr 18, 2019 • edited Loading

mmahkamov commented May 30, 2019

mmahkamov commented May 30, 2019 • edited Loading

sumitgohil commented Jun 26, 2019

mmahkamov commented Jun 27, 2019

sumitgohil commented Jun 27, 2019

kyleorin commented Jun 27, 2019

mmahkamov commented Jun 28, 2019

narayanansampath commented Sep 27, 2019

nimish1995 commented Sep 29, 2019

mmahkamov commented Sep 29, 2019

nimish1995 commented Sep 29, 2019

narayanansampath commented Sep 29, 2019

nimish1995 commented Sep 29, 2019

mmahkamov commented Oct 1, 2019

narayanansampath commented Oct 1, 2019

oliverbytes commented Oct 19, 2019

kmcgill88 commented Oct 19, 2019

oliverbytes commented Nov 1, 2019

edeuss commented Dec 19, 2019

trqalothman commented Jan 30, 2020

benevolent13 commented Feb 24, 2020

erperejildo commented Feb 26, 2020

erperejildo commented Feb 26, 2020

sumitgohil commented Feb 26, 2020 • edited Loading

edeuss commented Feb 27, 2020

erperejildo commented Feb 27, 2020

inartin commented Apr 18, 2019 •

edited

Loading

mmahkamov commented May 30, 2019 •

edited

Loading

sumitgohil commented Feb 26, 2020 •

edited

Loading