Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need iOS help? #2

Closed
kmcgill88 opened this issue Dec 19, 2018 · 19 comments · Fixed by #30
Closed

Need iOS help? #2

kmcgill88 opened this issue Dec 19, 2018 · 19 comments · Fixed by #30
Assignees
Labels
enhancement New feature or request

Comments

@kmcgill88
Copy link
Owner

Hi @YoussefKababe,

Awesome work on this plugin! I have an immediate need for banner and interstitial on Android and iOS. I'm newer to Flutter and am still researching PlatformViews however I have experience in iOS. Are you open to PR's?

@YoussefKababe
Copy link
Collaborator

Hi @kmcgill88! Happy that you found this useful and want to contribute. Thank you so much! I regret to tell you that the plugin is not open to PRs at the moment. It will be later when I feel it's in a good shape and has everything I planned to build. And between, I've made some good progress on iOS already and will release it in the next days!

@kmcgill88
Copy link
Owner Author

I understand completely. I will patiently wait to see your iOS work! In the meantime I will study up on the PlatformViews so I can help with some PR's if needed. Cheers!

@YoussefKababe
Copy link
Collaborator

Sounds amazing! This article from Felix was my starting point in the world of PlatformViews: https://medium.com/flutter-community/flutter-platformview-how-to-create-flutter-widgets-from-native-views-366e378115b6

There's also this recent one for creating PlatformViews with Swift: https://medium.com/@phoomparin/how-to-use-native-uis-in-flutter-with-swift-platform-view-8b4dc7f833d8

And there's as well official documentation from Flutter for iOS stuff: https://docs.flutter.io/objcdoc/Protocols/FlutterPlatformView.html

Cheers!

@kmcgill88
Copy link
Owner Author

Lol, I was just reading one of those! Thanks for sharing!

@kmcgill88
Copy link
Owner Author

Hey @YoussefKababe, any updates on iOS?

@ethanblake4
Copy link

ethanblake4 commented Jan 9, 2019

@kmcgill88 : since @YoussefKababe seems to be MIA, would you be interested in collaborating on a fork of this package with iOS support? I can handle future updates on the Android side, but I don't have a ton of iOS experience.

@kmcgill88
Copy link
Owner Author

Hi @ethanblake4, I found another solution for now on iOS. Hopefully @YoussefKababe get's some time to work on iOS. This is a promising plugin. If he doesn't respond soon I might take you up on the offer though.

@YoussefKababe
Copy link
Collaborator

Hi @ethanblake4 and @kmcgill88! I'm really sorry for not pushing updates for this package, and not having time to add iOS support. I'm having some busy days at my current day job, a lot of work and much time needed there. I will be happy to receive your PRs here guys, and I will also be back to work on this ASAP. I promise!

@praven07
Copy link

praven07 commented Mar 7, 2019

Hey @YoussefKababe are you gonna be doing the iOS support?

@ArthurianX
Copy link

@kmcgill88 - What is your solution for iOS ?

@kmcgill88
Copy link
Owner Author

@ArthurianX I have an existing lib for ios and admob. Check it out, https://github.com/kmcgill88/McAdViewController

It works but causes initial Flutter start time to be a bit slow. When I get some time I plan on adoing support to this lib for Flutter.

@ArthurianX
Copy link

@kmcgill88 - Thanks!

@c4talyst
Copy link

c4talyst commented Mar 16, 2019

Anyway some of this work can be PR’d into the firebase_admob plug-in? This is amazing - but have a need for iOS too - I’d be willing to donate / pay for this feature 🎉

@SachinGanesh
Copy link

SachinGanesh commented May 6, 2019

I understand completely. I will patiently wait to see your iOS work! In the meantime I will study up on the PlatformViews so I can help with some PR's if needed. Cheers!

@kmcgill88 Hi, We @dreamsoftin have implemented Facebook Audience Network for Flutter (https://github.com/dreamsoftin/facebook_audience_network). Currently the plugin is Android only and it supports Banner, Interstitial, Rewarded Video, In Stream Video & Native Ads. I'm looking for some one who can help us in implementing iOS part of it. May be you can help us in this?

Native Ad Demo:

@kmcgill88
Copy link
Owner Author

@SachinGanesh Thanks for reaching out. Right now I think I'm going to stick to getting admob_flutter up and running for iOS. @YoussefKababe you can add me as a maintainer if you'd like. I don't have a ton of time to dedicate to this project but having more than 1 able to merge PR's might be good.

@YoussefKababe
Copy link
Collaborator

@kmcgill88 I have just added you as a collaborator. Thank you so much for your time and your help!

@kmcgill88
Copy link
Owner Author

@YoussefKababe I got Banners working on iOS last night! Still working out some issues though. For some reason, I wasn't seeing the params passed from the Flutter side. I'm sure I'll get it. I'll keep you posted.

I plan to get Interstitial and rewards next then I will PR for review.

@kmcgill88
Copy link
Owner Author

If anyone else runs into an issue with a platform view not receiving args from Flutter, this post was the answer!

@kmcgill88 kmcgill88 added the enhancement New feature or request label May 23, 2019
@kmcgill88 kmcgill88 self-assigned this May 23, 2019
@kmcgill88
Copy link
Owner Author

kmcgill88 commented May 28, 2019

@YoussefKababe and anyone following this issue. Progress update: I have Interstitial ads working! I think I will have time this week to finish rewards. Then this plugin will have feature parity on Android and iOS! 🎉

@YoussefKababe I'm guessing you are the only one that has pub permission to publish an update. Are you interested in adding me or would you prefer to publish when this ticket is complete? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants