Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS Support #30

Merged
merged 11 commits into from
May 30, 2019
Merged

Add iOS Support #30

merged 11 commits into from
May 30, 2019

Conversation

kmcgill88
Copy link
Owner

@kmcgill88 kmcgill88 commented May 29, 2019

I did my best to keep the Swift implementation in sync with @YoussefKababe's Kotlin code. Not everything lines up exactly.

  1. I ended up registering 3 plugins. admob_flutter (the default), AdmobInterstitialPlugin and AdmobRewardPlugin.
  2. I'm not sure unique id's are required Interstitial and Reward but I followed suit for now. I think this should be revisited since Reward is a singleton in Swift and Interstitial's are one use and done.

Thanks for reviewing!

Closes #2

@kmcgill88 kmcgill88 requested a review from YoussefKababe May 29, 2019 04:53
}

// TODO: not sure this exists on iOS.
// channel.invokeMethod("impression", null)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anyone know if this exists on iOS?

ios/admob_flutter.podspec Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@YoussefKababe
Copy link
Collaborator

@kmcgill88 The above looks good to me! I'm approving the PR, and if you have tested it well and everything seems to work on your side as well, let's merge it! 🎉

@kmcgill88
Copy link
Owner Author

The only potential issue I've seen is related to banner ads. This only happens occasionally. I wouldn't think the test ads would do this? I'm pulling my fork into my app now. I will try with my real id's.

<Google> Cannot find an ad network adapter with the name(s): com.google.DummyAdapter. Remember to link all required ad network adapters and SDKs, and set -ObjC in the 'Other Linker Flags' setting of your build target.
Unsupported value: Error Domain=com.google.admob Code=8 "Request Error: Cannot find an ad network adapter for mediation." UserInfo={NSLocalizedDescription=Request Error: Cannot find an ad network adapter for mediation.} of type GADRequestError

@kmcgill88
Copy link
Owner Author

@YoussefKababe I think this is ready to go! 🚀 Please squash and merge when you have time to publish 0.3.0.

@YoussefKababe YoussefKababe merged commit 4639070 into kmcgill88:master May 30, 2019
@YoussefKababe
Copy link
Collaborator

@kmcgill88 Just merged and releases 0.3.0. Thank you so much for the awesome work! 🎉 🚀 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need iOS help?
4 participants