-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iOS Support #30
Add iOS Support #30
Conversation
…ios-support # Conflicts: # README.md
} | ||
|
||
// TODO: not sure this exists on iOS. | ||
// channel.invokeMethod("impression", null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anyone know if this exists on iOS?
@kmcgill88 The above looks good to me! I'm approving the PR, and if you have tested it well and everything seems to work on your side as well, let's merge it! 🎉 |
The only potential issue I've seen is related to banner ads. This only happens occasionally. I wouldn't think the test ads would do this? I'm pulling my fork into my app now. I will try with my real id's.
|
@YoussefKababe I think this is ready to go! 🚀 Please squash and merge when you have time to publish |
@kmcgill88 Just merged and releases |
I did my best to keep the Swift implementation in sync with @YoussefKababe's Kotlin code. Not everything lines up exactly.
admob_flutter
(the default),AdmobInterstitialPlugin
andAdmobRewardPlugin
.id
's are required Interstitial and Reward but I followed suit for now. I think this should be revisited since Reward is a singleton in Swift and Interstitial's are one use and done.Thanks for reviewing!
Closes #2