-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile revision info into binary #198
Comments
Does version here mean kmesh version? How can I get it? Can we pass these parameters(version, commit hash) using environment variables in: Lines 80 to 81 in 809e921
|
Right, we can pass from here.. FYI https://github.com/kurator-dev/kurator/blame/main/Makefile#L16 |
thanks! |
feat: support kmesh daemon version command(#198)
Done |
Task description:
We should compile version,commit hash, and build date into kmesh binary during build. And add version subcommand to allow printing that out.
So it can help developers to know whether they have tested the expected patch.
This is like
kubectl version
Solution:
Who can join or take the task:
The good first issue is intended for
first-time contributors
to get started on his/her contributor journey.After a contributor has successfully completed 1-2 good first issue's,
they should be ready to move on to
help wanted
items, saving the remaininggood first issue
for other new contributors.How to join or take the task:
Just reply on the issue with the message
/assign
in a separate line.Then, the issue will be assigned to you.
How to ask for help:
If you need help or have questions, please feel free to ask on this issue.
The issue author or other members of the community will guide you through the contribution process.
The text was updated successfully, but these errors were encountered: