Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E Enchancement] define command line flags for different cleanup granularity #522

Closed
YaoZengzeng opened this issue Jul 8, 2024 · 2 comments · Fixed by #649
Closed
Labels
kind/enhancement New feature or request

Comments

@YaoZengzeng
Copy link
Member

What would you like to be added:

Implement more command line flags for different cleanup granularity to make it more convenient for local run and debug flaky test case.

Now after running test/e2e/run_test.sh, infra like k8s, istio and Kmesh will not cleanup, but test applications will.

So add command line flag to implement such as:

  1. Cleanup all components: this seems simple, just use kind to delete the testing k8s cluster.
  2. Don't cleanup test applications: we can use istio.test.nocleanup which is the flag of istio integration framework to control it.

And more if it's necessary.

@YaoZengzeng YaoZengzeng added the kind/enhancement New feature or request label Jul 8, 2024
@YaoZengzeng
Copy link
Member Author

/assign @noobwei

@kmesh-bot
Copy link
Collaborator

@YaoZengzeng: GitHub didn't allow me to assign the following users: noobwei.

Note that only kmesh-net members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @noobwei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants