Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E Enchancement] define command line flags for different cleanup granularity #656

Open
1 of 2 tasks
YaoZengzeng opened this issue Jul 31, 2024 · 3 comments
Open
1 of 2 tasks
Labels
kind/enhancement New feature or request

Comments

@YaoZengzeng
Copy link
Member

What would you like to be added:

Implement more command line flags for different cleanup granularity to make it more convenient for local run and debug flaky test case.

Now after running test/e2e/run_test.sh, infra like k8s, istio and Kmesh will not cleanup, but test applications will.

So add command line flag to implement such as:

  • Cleanup all components: this seems simple, just use kind to delete the testing k8s cluster. Enable cleanup in e2e #649
  • Don't cleanup test applications: we can use istio.test.nocleanup which is the flag of istio integration framework to control it.
    And more if it's necessary.

NOTE: If there are multiple subtasks in an issue, when submitting a PR, you shoud use fix part of #xxx instead of directly using fix #xxx which will automatically close the entire issue.

@YaoZengzeng YaoZengzeng added the kind/enhancement New feature or request label Jul 31, 2024
@noobwei
Copy link
Contributor

noobwei commented Sep 19, 2024

According to #649 When we do not add CLEANUP_KIND or CLEANUP_REGISTRY, cleanup will not be performed by default. How should we handle the logic of cleanup? Do we need to change it to clean up all by default?

@YaoZengzeng
Copy link
Member Author

According to #649 When we do not add CLEANUP_KIND or CLEANUP_REGISTRY, cleanup will not be performed by default. How should we handle the logic of cleanup? Do we need to change it to clean up all by default?

It is OK not to clean up the kind cluster and registry by default.

However the test application will be deleted by default, We want flag to control the test application from being deleted. It's indeed a wrapper of istio.test.nocleanup which is used to keep the test applications and which can be used to troubleshoot when the test failed.

@noobwei
Copy link
Contributor

noobwei commented Oct 25, 2024

The second task has been fixed by #906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants