E2E Enhancement Draft #906
Conversation
Signed-off-by: noobwei <ta22230@bristol.ac.uk>
kmesh-bot
added
do-not-merge/work-in-progress
kind/enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 80 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: noobwei <ta22230@bristol.ac.uk>
| @@ -909,3 +910,37 @@ func PromDiff(t test.Failer, prom prometheus.Instance, cluster cluster.Cluster, | |||
|
|
|||
| } | |||
| } | |||
|
|
|||
| func TestServiceRestart(t *testing.T) { | |||
There was a problem hiding this comment.
This case fails and needs to be fixed.
There was a problem hiding this comment.
donot we already have a restart case?
There was a problem hiding this comment.
donot we already have a restart case?
We have Kmesh daemon restart case and this is the restart of applications.
test/e2e/baseline_test.go
Outdated
| }).Start() | ||
| generators = append(generators, g) | ||
| } | ||
| mkGen(dst) |
There was a problem hiding this comment.
| mkGen(dst) | |
| apps.ServiceWithWaypointAtServiceGranularity[0] |
Not use dst itself as src.
test/e2e/baseline_test.go
Outdated
| Port: echo.Port{ | ||
| Name: "http", | ||
| }, | ||
| Retry: echo.Retry{NoRetry: true}, |
There was a problem hiding this comment.
Remove this line, as it takes time to send new endpoints to eBPF. So we need retry.
Signed-off-by: noobwei <ta22230@bristol.ac.uk>
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YaoZengzeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: