-
Notifications
You must be signed in to change notification settings - Fork 132
add configuration to collect the Prometheus metrics from Kmesh and rename them into a format that Kiali can read. #1085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add configuration to collect the Prometheus metrics from Kmesh and rename them into a format that Kiali can read. #1085
Conversation
|
@delavet: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Welcome @delavet! It looks like this is your first PR to kmesh-net/kmesh 🎉 |
420670f to
16a135c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
/lgtm |
|
@delavet What does the graph drawn by kiali look like now with the config |
…name them into a format that Kiali can read. Signed-off-by: 露营 <luying.yh@alibaba-inc.com>
Signed-off-by: 露营 <luying.yh@alibaba-inc.com>
87cf7a5 to
9a83ef7
Compare
I just got some update here. The Prometheus configuration file is updated and with this configuration we can get a pretty decent traffic graph like this. We can see there are blue edges (tcp traffics) between services whose traffics are proxied by Kmesh, and green edges (http traffics) between services whose traffics are proxied by Waypoint. The service node name seems not behavior the same as Istio standard metrics. I have just submitted a new issue to track this here: #1089 |
hzxuzhonghu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
so, is the kiali configuration consistent with |
not exactly the same. Actually, I use helm to install kiali following https://kiali.io/docs/installation/installation-guide/install-with-helm/. However, I believe the only difference is the external_service config in the kiali ConfigMap. This is because we should make kiali read Prometheus deployed in kmesh-system. I prefer to use helm and adjust some values in the later documentation. |

What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR supplies a new Prometheus configuration file in Kmesh samples. Compared with the origin one in
samples/addons/prometheus.yaml, this new Prometheus configuration file adds some modifications to help Kiali drawing Traffic Graph based on metrics generated by Kmesh.reporter=waypointlabel toreporter=destination. Through this relabel config, Kiali can read http metrics exposed by waypoint without having to recognize that the data plane is in Ambient Mode. In this way, Kiali can draw http Traffic Graph when data plane mode is Kmesh.A document utilizing this prometheus configuration file to visualize Traffic Graph in Kiali under Kmesh will be given later.
Which issue(s) this PR fixes:
Fixes #1033
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
No, this just supplies a sample prometheus configuration which will be used in documentations.