add ut of ads_loader.go #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzxuzhonghu
reviewed
Mar 25, 2024
|
I'll add test cases later. |
LiZhenCheng9527
force-pushed
the
ut-ads-loader
branch
from
3ae18fb to
ad83d5d
Compare
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
LiZhenCheng9527
force-pushed
the
ut-ads-loader
branch
from
ad83d5d to
5e127bb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Flags with carried forward coverage won't be shown. Click here to find out more. |
nlgwcy
reviewed
May 25, 2024
pkg/controller/ads/cache_test.go
Outdated
| @@ -0,0 +1,623 @@ | |||
| /* | |||
| * Copyright 2023 The Kmesh Authors. | |||
There was a problem hiding this comment.
Copyright 2024 The Kmesh Authors.
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlgwcy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
add ut of ads_loader.go
Which issue(s) this PR fixes:
a part of #104