add ut of client.go #213
Merged
add ut of client.go #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
LiZhenCheng9527
commented
Apr 10, 2024
| "kmesh.net/kmesh/pkg/nets" | ||
| ) | ||
|
|
||
| type MockDiscovery struct { |
There was a problem hiding this comment.
This function will be processed later
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
LiZhenCheng9527
force-pushed
the
ut-client
branch
from
89e27db to
d643508
Compare
hzxuzhonghu
reviewed
Apr 11, 2024
| return nil | ||
| } | ||
| }) | ||
| err := utClient.recoverConnection() |
There was a problem hiding this comment.
please do some more meaningful test.
hzxuzhonghu
reviewed
Apr 11, 2024
| } else { | ||
| utClient.cancel() | ||
| return nil | ||
| } |
There was a problem hiding this comment.
add some comments about this, it is confusing
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add ut of client.go
Which issue(s) this PR fixes:
a part of #104