add clang-format #266
Merged
add clang-format #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzxuzhonghu
commented
Apr 23, 2024
| bpf_ringbuf_submit(msg, 0); | ||
| } | ||
|
|
||
| static inline void enable_encoding_metadata(struct bpf_sock_ops *skops) |
There was a problem hiding this comment.
removed this function
There was a problem hiding this comment.
The enable_encoding_metadata function adds the sock to the sockhashmap. Kernel replaces the sendmsg hook (tcp_bpf_sendmsg) of the sock and then triggers the BPF prog of the sk_msg. Otherwise, there is no bpf hook in the normal tcp_sendmsg.
nlgwcy
reviewed
Apr 25, 2024
bpf/kmesh/workload/sendmsg.c
Outdated
| break; | ||
| } | ||
| switch (type) | ||
| { |
nlgwcy
reviewed
Apr 25, 2024
bpf/kmesh/workload/sockops_tuple.c
Outdated
| __u32 type; | ||
| struct bpf_sock_tuple tuple; | ||
| struct ringbuf_msg_type | ||
| { |
nlgwcy
reviewed
Apr 25, 2024
bpf/kmesh/workload/sendmsg.c
Outdated
| return 1; | ||
| } | ||
| if (ret) | ||
| { |
hzxuzhonghu
force-pushed
the
clang-format
branch
2 times, most recently
from
20678d7 to
4f542ee
Compare
nlgwcy
reviewed
Apr 26, 2024
| fd = bpf_create_map_name(inner_info->type, NULL, inner_info->key_size, | ||
| inner_info->value_size, inner_info->max_entries, | ||
| inner_info->map_flags); | ||
| fd = bpf_create_map_name(inner_info->type, NULL, inner_info->key_size, inner_info->value_size, inner_info->max_entries, inner_info->map_flags); |
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
hzxuzhonghu
force-pushed
the
clang-format
branch
from
5ce75e8 to
9ccab28
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlgwcy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Format c files
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: