FIX bpf_map_delete_elem unexpected error log #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
hzxuzhonghu
force-pushed
the
fix-unexpected-error
branch
from
c72eba2 to
4ebf249
Compare
nlgwcy
reviewed
May 7, 2024
| @@ -199,8 +198,7 @@ int record_tuple(struct bpf_sock_ops *skops) | |||
| auth_ip_tuple(skops); | |||
| break; | |||
| case BPF_SOCK_OPS_STATE_CB: | |||
| if (skops->args[1] == BPF_TCP_CLOSE || skops->args[1] == BPF_TCP_CLOSE_WAIT | |||
| || skops->args[1] == BPF_TCP_FIN_WAIT1) { | |||
| if (skops->args[1] == BPF_TCP_CLOSE) { | |||
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlgwcy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
We areusing bpf_map_delete_elem which returns longs type. We see very weired phenomenon though it is -2 when no key exists, but it is not equal to int -2.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: