Kmesh: repair kmesh manager not effect in sockops on oe 23.03 #301
Conversation
sockops port is not same as other linux vendor. We need to adapt oe 23.03. Signed-off-by: bitcoffee <liuxin350@huawei.com>
| @@ -155,15 +155,19 @@ static inline bool conn_from_cni_sim_add(struct bpf_sock_ops *skops) | |||
| #if !OE_23_03 | |||
| return ((bpf_ntohl(skops->remote_ip4) == 1) && (bpf_ntohl(skops->remote_port) == 0x3a1)); | |||
| #else | |||
| return ((bpf_ntohl(skops->remote_ip4) == 1) && (bpf_ntohl(skops->remote_port) == 0xa1030000)); | |||
| return ((bpf_ntohl(skops->remote_ip4) == 1) && (bpf_ntohl(skops->remote_port) == 0x3a10000)); | |||
There was a problem hiding this comment.
Is this only OE2303 behaves like this? And how about the other os releases?
There was a problem hiding this comment.
Yes, this is a bug in OE2303. However, OE2303 has only a half-year maintenance period. Now OE2303 is no longer updated. Therefore, we need to determine the OE2303 policy and whether to continue the maintenance support.
There was a problem hiding this comment.
Good to know. We can discuss on community meeting.
But this fix makes sense
|
/cherry-pick release-0.3 |
|
@hzxuzhonghu: once the present PR merges, I will cherry-pick it on top of release-0.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The context of release 0.3 is not completely consistent, and cherry-pick may fail. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hzxuzhonghu: #301 failed to apply on top of branch "release-0.3": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@hzxuzhonghu: new issue created for failed cherrypick: #304 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sockops port is not same as other linux vendor. We need to adapt oe 23.03.
What type of PR is this?
/kind bug
What this PR does / why we need it:
repair issue #298
Which issue(s) this PR fixes:
Fixes #
#298
Special notes for your reviewer:
NA
Does this PR introduce a user-facing change?:
NA