Added dns resolver proposal #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
docs/proposal/dns_resolve.md
Outdated
| A good summary is probably at least a paragraph in length. | ||
| --> | ||
|
|
||
| Envoy supports many different cluster types, including `Strict Dns`, `Logical DNS`. However, given to kmesh works in the kernel with ebpf. Previously kmesh does not either of the DNS typed clusters. For traffic matches these kind of cluster, it will be dropped. |
There was a problem hiding this comment.
Suggested change
| Envoy supports many different cluster types, including `Strict Dns`, `Logical DNS`. However, given to kmesh works in the kernel with ebpf. Previously kmesh does not either of the DNS typed clusters. For traffic matches these kind of cluster, it will be dropped. | |
| Envoy supports many different cluster types, including `Strict Dns`, `Logical DNS`. However, given to Kmesh works in the kernel with ebpf. Previously Kmesh does not either of the DNS typed clusters. For traffic matches these kind of cluster, it will be dropped. |
docs/proposal/dns_resolve.md
Outdated
| this KEP. Describe why the change is important and the benefits to users. | ||
| --> | ||
|
|
||
| In istio, [External Name service](https://kubernetes.io/docs/concepts/services-networking/service/#externalname) and DNS resolution typed ServiceEntry are widely used. For both kind of configs, istiod will generate associated DNS typed clusters. |
There was a problem hiding this comment.
Suggested change
| In istio, [External Name service](https://kubernetes.io/docs/concepts/services-networking/service/#externalname) and DNS resolution typed ServiceEntry are widely used. For both kind of configs, istiod will generate associated DNS typed clusters. | |
| In istio, [External Name service](https://kubernetes.io/docs/concepts/services-networking/service/#externalname) and [DNS resolution typed ServiceEntry](https://istio.io/latest/docs/reference/config/networking/service-entry/) are widely used. For both kind of configs, istiod will generate associated DNS typed clusters. |
docs/proposal/dns_resolve.md
Outdated
| nitty-gritty. | ||
| --> | ||
|
|
||
| We shold implement a new component to do dns resove, called `dns resolver`. It should basically do: |
There was a problem hiding this comment.
Suggested change
| We shold implement a new component to do dns resove, called `dns resolver`. It should basically do: | |
| We shold implement a new component to do dns resolve, called `dns resolver`. It should basically do: |
| @@ -0,0 +1,218 @@ | |||
| --- | |||
| title: Your short, descriptive title | |||
There was a problem hiding this comment.
The title doesn't seem to have changed.
| "metadata": { | ||
| "filterMetadata": { | ||
| "istio": { | ||
| "workload": ";;;;" |
There was a problem hiding this comment.
What is the meaning of this line?
There was a problem hiding this comment.
This is a composed string including some metadata from pod. If these are empty, then it will be this type
| nitty-gritty. | ||
| --> | ||
|
|
||
| We shold implement a new component to do dns resolve, called `dns resolver`. It should basically do: |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlgwcy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: