Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional of start bypass #306

Merged
merged 3 commits into from
May 15, 2024

Conversation

LiZhenCheng9527
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:
add optional of start bypass, default is false
Which issue(s) this PR fixes:
Fixes #294

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


pkg/controller/controller.go Outdated Show resolved Hide resolved
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
deploy/helm/values.yaml Outdated Show resolved Hide resolved
pkg/bpf/config.go Outdated Show resolved Hide resolved
pkg/controller/controller.go Outdated Show resolved Hide resolved
pkg/controller/controller.go Outdated Show resolved Hide resolved
daemon/options/bpf.go Outdated Show resolved Hide resolved
daemon/options/bpf.go Outdated Show resolved Hide resolved
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@kmesh-bot kmesh-bot added size/M and removed size/S labels May 13, 2024
hzxuzhonghu
hzxuzhonghu previously approved these changes May 13, 2024
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weli-l can you also take a look

daemon/options/bypass.go Outdated Show resolved Hide resolved
deploy/helm/values.yaml Outdated Show resolved Hide resolved
pkg/controller/controller.go Outdated Show resolved Hide resolved
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@hzxuzhonghu
Copy link
Member

/lgtm

@hzxuzhonghu
Copy link
Member

/approve

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit c431a52 into kmesh-net:main May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bypass controller should not be coupled ads or worklaod mode
5 participants