Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Enhanced Compilation Failure Issue #309

Merged
merged 1 commit into from
May 9, 2024

Conversation

lec-bit
Copy link
Contributor

@lec-bit lec-bit commented May 9, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: lec-bit <glfhmzmy@126.com>
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lec-bit

/lgtm

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 47ca5f4 into kmesh-net:main May 9, 2024
3 checks passed
@bfforever
Copy link
Member

func NewBpfKmesh(cfg *options.BpfConfig) (BpfKmesh, error) {

sc := BpfKmesh{}

Maybe above two place need to change Bpfmesh to reference type to fix enhanced complilation failure.

@hzxuzhonghu
Copy link
Member

In theory this is better to return pointer type in case there is some copy and we mutate the original object later . @lec-bit @bfforever Did you test the features with this patch, i canot see where we copy it

@bfforever
Copy link
Member

My development machine is enhanced kernel, go build would build with bpf_kmesh.go file, not bpf_kmesh_l4.go file, so would report a inconsistent type error at compile time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants