Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update listener benchmark #328

Merged
merged 2 commits into from
May 15, 2024

Conversation

LiZhenCheng9527
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:
A random address is set for the listener in the test case
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@LiZhenCheng9527 LiZhenCheng9527 force-pushed the change-listener-bench branch from f2bcf24 to 0d29f89 Compare May 15, 2024 02:48
func randomIPv4() string {
ip := uint32(rand.Intn(256))<<24 | uint32(rand.Intn(256))<<16 | uint32(rand.Intn(256))<<8 | uint32(rand.Intn(256))

return fmt.Sprintf("%d.%d.%d.%d", ip&0xff000000>>24, ip&0x00ff0000>>16, ip&0x0000ff00>>8, ip&0x000000ff)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be optimized

Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@LiZhenCheng9527 LiZhenCheng9527 force-pushed the change-listener-bench branch from 5fae108 to 040c973 Compare May 15, 2024 09:03
@kmesh-bot kmesh-bot added size/XS and removed size/S labels May 15, 2024
@nlgwcy
Copy link
Contributor

nlgwcy commented May 15, 2024

/lgtm
/approve

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlgwcy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 94db814 into kmesh-net:main May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants