Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bpf-map test failed #341

Merged
merged 1 commit into from
May 20, 2024
Merged

fix bpf-map test failed #341

merged 1 commit into from
May 20, 2024

Conversation

nlgwcy
Copy link
Contributor

@nlgwcy nlgwcy commented May 19, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #340

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@kmesh-bot kmesh-bot added the kind/bug Something isn't working label May 19, 2024
@@ -22,6 +22,7 @@ import (
"syscall"
"testing"

"github.com/cilium/ebpf/rlimit"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A blank line is needed here to distinguish the third-party kpg from Kmesh's pkg

hzxuzhonghu
hzxuzhonghu previously approved these changes May 20, 2024
@hzxuzhonghu
Copy link
Member

@LiZhenCheng9527 can we run the bench in the ci

Signed-off-by: wuchangye <wuchangye@huawei.com>
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 29309db into kmesh-net:main May 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to run cluster_test.go
4 participants