Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codecov config #537

Merged
merged 3 commits into from
Jul 10, 2024
Merged

add codecov config #537

merged 3 commits into from
Jul 10, 2024

Conversation

LiZhenCheng9527
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:
add codecov config
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@LiZhenCheng9527
Copy link
Collaborator Author

LiZhenCheng9527 commented Jul 10, 2024

/cc @hzxuzhonghu Please update CODECOV_TOKEN refer to https://docs.codecov.com/docs/quick-start#step-4-upload-coverage-reports-to-codecov

This is Kmesh codecov TOKEN:https://app.codecov.io/gh/kmesh-net/kmesh/settings

Only OWNER can update TOKEN

.codecov.yml Outdated
default:
# basic
target: auto #default
threshold: 35%
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does 35% apply to new added code?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a threshold.
Now the overall UT coverage of the Kmesh is36.06%.
If a new commit causes project coverage to fall below 35%, an alarm is raised.

@@ -0,0 +1,8 @@
coverage:
status:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.00%. Comparing base (837856d) to head (548ebc1).
Report is 387 commits behind head on main.

see 45 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 837856d...548ebc1. Read the comment docs.

Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
@hzxuzhonghu
Copy link
Member

/lgtm

/approve

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 9c3c136 into kmesh-net:main Jul 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants