-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add codecov config #537
add codecov config #537
Conversation
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
/cc @hzxuzhonghu Please update CODECOV_TOKEN refer to https://docs.codecov.com/docs/quick-start#step-4-upload-coverage-reports-to-codecov This is Kmesh codecov TOKEN:https://app.codecov.io/gh/kmesh-net/kmesh/settings Only OWNER can update TOKEN |
.codecov.yml
Outdated
default: | ||
# basic | ||
target: auto #default | ||
threshold: 35% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does 35% apply to new added code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a threshold.
Now the overall UT coverage of the Kmesh is36.06%.
If a new commit causes project coverage to fall below 35%, an alarm is raised.
@@ -0,0 +1,8 @@ | |||
coverage: | |||
status: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need comment https://docs.codecov.com/docs/pull-request-comments
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 45 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
/lgtm /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
add codecov config
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: