Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bpf log level getter (#560) #562

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Add bpf log level getter (#560) #562

merged 3 commits into from
Jul 12, 2024

Conversation

Okabe-Rintarou-0
Copy link
Member

What type of PR is this?

bug

What this PR does / why we need it:
image
Which issue(s) this PR fixes:
Fixes #560

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@Okabe-Rintarou-0
add bpf log level getter
c213cdd 
Signed-off-by: 923048992@qq.com <923048992@qq.com>
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.28571% with 15 lines in your changes missing coverage. Please review.

Project coverage is 49.25%. Comparing base (098a402) to head (6ac828c).
Report is 9 commits behind head on main.

Files Coverage Δ
pkg/status/status_server.go 33.18% <64.28%> (+6.98%) ⬆️

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb0bd28...6ac828c. Read the comment docs.

hzxuzhonghu
hzxuzhonghu reviewed Jul 11, 2024
View reviewed changes
daemon/helper/helper.go Outdated
func GetJson(url string, val any) {
resp, err := http.Get(url)
if err != nil {
fmt.Printf("Error making GET request: %v\n", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: log url as well

daemon/helper/helper.go Outdated
@@ -0,0 +1,35 @@
package helper
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we donot need to put it in a separate pkg

@Okabe-Rintarou-0
optimize logic and add some more uts
3add8f4 
Signed-off-by: 923048992@qq.com <923048992@qq.com>
@Okabe-Rintarou-0
fix lint
6ac828c 
Signed-off-by: 923048992@qq.com <923048992@qq.com>
@LiZhenCheng9527
Copy link
Collaborator

/lgtm

@kmesh-bot kmesh-bot added the lgtm label Jul 11, 2024
hzxuzhonghu
hzxuzhonghu approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit de74f6b into kmesh-net:main Jul 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@supercharge-xsy supercharge-xsy Awaiting requested review from supercharge-xsy

Assignees

@hzxuzhonghu hzxuzhonghu

@LiZhenCheng9527 LiZhenCheng9527

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bpf logger not exist
4 participants
@Okabe-Rintarou-0 @LiZhenCheng9527 @kmesh-bot @hzxuzhonghu