-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E test cases for service and pod ip access #596
Conversation
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@hzxuzhonghu PTAL |
cool |
test/e2e/baseline_test.go
Outdated
@@ -51,6 +78,82 @@ var ( | |||
} | |||
) | |||
|
|||
func supportsL7(opt echo.CallOptions, src, dst echo.Instance) bool { | |||
s := src.Config().HasSidecar() | |||
d := dst.Config().HasSidecar() || dst.Config().HasAnyWaypointProxy() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove sidecar, it is not in kmesh e2e
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@hzxuzhonghu PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Add E2E test cases of service and pod access, test whether the access is possible and whether it has been properly processed by L7, etc
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: