Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove resync period #601

Merged
merged 2 commits into from
Jul 19, 2024
Merged

remove resync period #601

merged 2 commits into from
Jul 19, 2024

Conversation

hzxuzhonghu
Copy link
Member

@hzxuzhonghu hzxuzhonghu commented Jul 18, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #597

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.57%. Comparing base (eb828ce) to head (df1c32c).
Report is 32 commits behind head on main.

Files Coverage Δ
pkg/controller/bypass/bypass_controller.go 37.79% <100.00%> (ø)
pkg/controller/manage/kmesh_manage.go 58.66% <100.00%> (-2.00%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a0534f...df1c32c. Read the comment docs.

LabelSelectorBypass = "kmesh.net/bypass=enabled"
KmeshAnnotation = "kmesh.net/redirection"
SidecarAnnotation = "sidecar.istio.io/inject"
KmeshAnnotation = "kmesh.net/redirection"
Copy link
Collaborator

@LiZhenCheng9527 LiZhenCheng9527 Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a KmeshRedirectionAnnotation in constant.go

KmeshRedirectionAnnotation = "kmesh.net/redirection"

Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@nlgwcy
Copy link
Contributor

nlgwcy commented Jul 19, 2024

/lgtm
/approve

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlgwcy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit d0f10ea into kmesh-net:main Jul 19, 2024
7 checks passed
@hzxuzhonghu hzxuzhonghu deleted the rm-resync branch July 19, 2024 06:35
@hzxuzhonghu hzxuzhonghu restored the rm-resync branch July 19, 2024 07:41
@hzxuzhonghu hzxuzhonghu deleted the rm-resync branch July 19, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove default resync period
4 participants