Fix DNS cluster's endpoint ip addr check #604
Conversation
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
LiZhenCheng9527
force-pushed
the
add-ut-dns
branch
from
2f330c8 to
3f89cdf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
pkg/dns/dns_test.go
Outdated
| Address: &v3.Address{ | ||
| Address: &v3.Address_SocketAddress{ | ||
| SocketAddress: &v3.SocketAddress{ | ||
| Address: "192.168.10.244", |
There was a problem hiding this comment.
we need a case this is a domain
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
pkg/dns/dns_test.go
Outdated
| domainName: "192.168.10.244", | ||
| clusters: []*clusterv3.Cluster{utCluster[0]}, | ||
| "192.168.2.1": { | ||
| domainName: "192.168.2.1", |
There was a problem hiding this comment.
This will need to be update, can you take over the commit from @nlgwcy if he agrees
pkg/dns/dns.go
Outdated
| if _, err := netip.ParseAddr(address); err != nil { | ||
| // This is an ip address | ||
| if _, err := netip.ParseAddr(address); err == nil { | ||
| // This is an host |
hzxuzhonghu
changed the title
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
LiZhenCheng9527
force-pushed
the
add-ut-dns
branch
from
8bac809 to
96f2545
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created: #616 |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: