Support ipv6 in e2e test #621
Conversation
Signed-off-by: noobwei <ta22230@bristol.ac.uk>
|
Welcome @noobwei! It looks like this is your first PR to kmesh-net/kmesh 🎉 |
| @@ -28,7 +28,25 @@ function setup_kind_cluster() { | |||
| fi | |||
|
|
|||
| # Create KinD cluster. | |||
| cat <<EOF | kind create cluster --name="${NAME}" -v4 --retain --image "${IMAGE}" --config=- | |||
|
|
|||
There was a problem hiding this comment.
You should also add a line here for ipv6 e2e call:
https://github.com/kmesh-net/kmesh/blob/main/Makefile#L149
| @@ -28,7 +28,25 @@ function setup_kind_cluster() { | |||
| fi | |||
|
|
|||
| # Create KinD cluster. | |||
| cat <<EOF | kind create cluster --name="${NAME}" -v4 --retain --image "${IMAGE}" --config=- | |||
|
|
|||
| if [[ -n "${IPV6:-}" ]]; then | |||
There was a problem hiding this comment.
This if has no corresponding fi?
Signed-off-by: noobwei <ta22230@bristol.ac.uk>
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -148,6 +148,8 @@ docker.push: docker | |||
|
|
|||
| e2e: | |||
There was a problem hiding this comment.
Make ipv6 an env, if we want to run e2e test for ipv6 run:
IPFAMILY=ipv6 make e2e
Signed-off-by: noobwei <ta22230@bristol.ac.uk>
.github/workflows/e2e.yml
Outdated
| @@ -20,3 +20,22 @@ jobs: | |||
| shell: bash | |||
| run: | | |||
| sudo make e2e | |||
|
|
|||
| e2e-ipv6-test: | |||
There was a problem hiding this comment.
why not separate it to e2e-ipv6.yml
Signed-off-by: noobwei <ta22230@bristol.ac.uk>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Support pure ipv6 in e2e test, to fit in the new feature in Kmesh
Which issue(s) this PR fixes:
Fixes #529
Special notes for your reviewer:
Does this PR introduce a user-facing change?: