E2E test cases for waypoint management #625
Conversation
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
kmesh-bot
added
kind/enhancement
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
YaoZengzeng
force-pushed
the
waypoint-management
branch
from
fd15b32 to
d18d564
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
test/e2e/baseline_test.go
Outdated
| } | ||
| t.NewSubTestf("from %v", src.Config().Service).Run(func(t framework.TestContext) { | ||
| c := IsL4() | ||
| if src.Config().HasSidecar() { |
There was a problem hiding this comment.
nit: remove, always check L4 here
|
/lgtm |
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
YaoZengzeng
changed the title
|
|
||
| // Test add/remove waypoint at ns or service granularity. | ||
| func TestRemoveAddNsOrServiceWaypoint(t *testing.T) { | ||
| for _, granularity := range []Granularity{Service /*,Namespace*/} { |
There was a problem hiding this comment.
@hzxuzhonghu maybe this PR could be merged first, when #628 get fixed, then we uncomment Namespace
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it
e2e tests for waypoint management:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: