-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kmesh_deploy_and_develop_in_kind.md #904
Conversation
``` | ||
|
||
`make build` will generate kmeshctl in the kmesh directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After v0.5.0 release, kmeshctl
will be included in the release tarball, and we could use it directly without compiling it on site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed it.
@@ -121,12 +121,12 @@ You can follow the steps below to develop in kind: | |||
You can change the logger level by: | |||
|
|||
```shell | |||
kubectl exec -it $kmesh_pod_name -n kmesh-system -- kmesh-daemon log --set default:debug | |||
./kmeshctl log $kmesh_pod_name --set default:debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./kmeshctl log $kmesh_pod_name --set default:debug | |
kmeshctl log $kmesh_pod_name --set default:debug |
Specially, for bpf logs: | ||
```shell | ||
kubectl exec -it $kmesh_pod_name -n kmesh-system -- kmesh-daemon log --set bpf:debug | ||
./kmeshctl log $kmesh_pod_name --set bpf:debug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
``` | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove white spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@derekwin you should sign-off your every commits to pass |
9fffc1e
to
ac06104
Compare
Signed-off-by: derekwin <jacelau@outlook.com>
ac06104
to
ab51e5d
Compare
ok |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: YaoZengzeng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation