-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable/disable accesslog with kmeshctl #935
Conversation
/cc @YaoZengzeng PTAL |
@LiZhenCheng9527: GitHub didn't allow me to request PR reviews from the following users: PTAL. Note that only kmesh-net members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAttention: Patch coverage is
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
0d85d7b
to
0a4919a
Compare
patternAccesslog = "/accesslog" | ||
) | ||
|
||
var log = logger.NewLoggerScope("kmeshctl/accesslog") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everytime we use a logger we need to init one, i do think we can provide a default logger in the package. So in some common place, it can be used
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
cc58f8a
to
1f62ed1
Compare
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #925
Special notes for your reviewer:
Does this PR introduce a user-facing change?: