Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github action arm image built #948

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

hzxuzhonghu
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

: without this, though the docker image is ar,64 arch but the kmesh-daemon within it is just x86-64.

Which issue(s) this PR fixes:
Fixes #944

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


…t is x86-64 arch

Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
…t is x86-64 arch

Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.28%. Comparing base (739fde5) to head (6884bde).
Report is 16 commits behind head on main.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85ca41...6884bde. Read the comment docs.

@@ -0,0 +1,26 @@
FROM ghcr.io/kmesh-net/kmesh-build:latest AS builder
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need a new dockerfile?Why not modify the original dockerfile?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a temparary fix. Becase that @weli-l found before #742, it failed to build using docker 18.09

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@LiZhenCheng9527
Copy link
Collaborator

/lgtm

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu
Copy link
Member Author

I will merge this manually, since this is influcencing arm deploy

@kmesh-bot kmesh-bot merged commit e83536b into kmesh-net:main Oct 14, 2024
9 checks passed
@hzxuzhonghu
Copy link
Member Author

/cherry-pick release-0.5

@kmesh-bot
Copy link
Collaborator

@hzxuzhonghu: new pull request created: #953

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hzxuzhonghu
Copy link
Member Author

/cherrypick release-0.5

@kmesh-bot
Copy link
Collaborator

@hzxuzhonghu: new pull request could not be created: failed to create pull request against kmesh-net/kmesh#release-0.5 from head kmesh-bot:cherry-pick-948-to-release-0.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for kmesh-bot:cherry-pick-948-to-release-0.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherrypick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hzxuzhonghu
Copy link
Member Author

/label cherrypick/release-0.5

@kmesh-bot
Copy link
Collaborator

@hzxuzhonghu: The label(s) /label cherrypick/release-0.5 cannot be applied. These labels are supported: tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label cherrypick/release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hzxuzhonghu hzxuzhonghu deleted the fix-arm-image branch October 14, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[release 0.5]Binary in Kmesh arm image not exec properly
3 participants