Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump istio dependencies #950

Merged
merged 7 commits into from
Oct 17, 2024
Merged

Bump istio dependencies #950

merged 7 commits into from
Oct 17, 2024

Conversation

hzxuzhonghu
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

#927
#928 failure have some relationship with istio

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@@ -1,6 +1,3 @@
//go:build integ
// +build integ
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @YaoZengzeng why did we need this tag

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used to seperate test files, we will use it in: https://github.com/kmesh-net/kmesh/blob/main/test/e2e/run_test.sh#L278 .

Although all the files in ./test/e2e/ are used to e2e test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revert

Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.43%. Comparing base (739fde5) to head (d119669).
Report is 36 commits behind head on main.

Files with missing lines Coverage Δ
pkg/controller/client.go 66.66% <100.00%> (+1.23%) ⬆️
pkg/controller/manage/manage_controller.go 52.86% <100.00%> (-2.21%) ⬇️
pkg/controller/security/manager.go 92.37% <100.00%> (ø)
pkg/dns/dns.go 75.94% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b85ca41...d119669. Read the comment docs.

@nlgwcy
Copy link
Contributor

nlgwcy commented Oct 17, 2024

/retest

@nlgwcy
Copy link
Contributor

nlgwcy commented Oct 17, 2024

/lgtm
/approve

@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlgwcy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit e5b8028 into kmesh-net:main Oct 17, 2024
9 checks passed
@hzxuzhonghu hzxuzhonghu deleted the bump-istio branch October 18, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants