Add Comprehensive Circuit Breaker User Guide for KMesh Kernel-Native Implementation #110
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kmesh-net ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DeshDeepakKant
force-pushed
the
docs/circuit-breaker
branch
from
6448517 to
db6f23f
Compare
| @@ -0,0 +1,253 @@ | |||
| --- | |||
| draft: false | |||
| linktitle: Circuit Breaker | |||
There was a problem hiding this comment.
@DeshDeepakKant Is not from China, he does not speak Chinese
| spec: | ||
| containers: | ||
| - name: service | ||
| image: your-service-image |
There was a problem hiding this comment.
We should provide a runnable application, please refer to other guide
|
|
||
| ```bash | ||
| # Install hey load testing tool | ||
| go install github.com/rakyll/hey@latest |
There was a problem hiding this comment.
OK, can use fortio (https://github.com/kmesh-net/kmesh/tree/main/samples/fortio) as well
| go install github.com/rakyll/hey@latest | ||
|
|
||
| # Generate load | ||
| hey -n 1000 -c 50 http://sample-service/endpoint |
There was a problem hiding this comment.
I am not sure how ciercuit breaking work as this is run from a binary, how is the client managed by kmesh
|
|
||
| ```bash | ||
| # View KMesh circuit breaker logs | ||
| kubectl logs -n kmesh -l app=kmesh circuit-breaker |
There was a problem hiding this comment.
@hzxuzhonghu Thank you for the review. I have made the changes and pushed them. The updates are running smoothly and have been verified on my end. If any further adjustments are needed, please let me know.
Additionally, I've attached some terminal logs for your reference. Could you please confirm if everything looks correct?
|
Can you be sure that what you are submitting is verified by yourself? |
DeshDeepakKant
force-pushed
the
docs/circuit-breaker
branch
2 times, most recently
from
5295889 to
2545431
Compare
…uide - Implement detailed documentation for Circuit Breaker feature - Include technical implementation details - Provide configuration examples and best practices - Cover troubleshooting and monitoring aspects Signed-off-by: Desh Deepak Kant <deshdeepakkant@gmail.com> Closes kmesh-net#103 Signed-off-by: DeshDeepakKant <deshdeepakkant@gmail.com>
Signed-off-by: DeshDeepakKant <deshdeepakkant@gmail.com>
Signed-off-by: DeshDeepakKant <deshdeepakkant@gmail.com>
DeshDeepakKant
force-pushed
the
docs/circuit-breaker
branch
from
2545431 to
4bc5264
Compare
|
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| fortio load -c 2 -qps 20 -t 30s http://test-service | ||
| ``` | ||
|
|
||
| ### Analyzing Results |
There was a problem hiding this comment.
Can you show the results as well?
Logs or metrics are fine
Description
During the Open Source Promotion Plan (OSPP), KMesh has successfully implemented a circuit breaker mechanism in Kernel-Native mode. However, the current documentation lacks a comprehensive user guide to help developers understand and utilize this feature effectively.
Objectives
Key Components