Skip to content

Conversation

@DeshDeepakKant
Copy link
Contributor

@DeshDeepakKant DeshDeepakKant commented Feb 1, 2025

What this PR does:

Currently, the website does not support dark mode, which can be a strain on the eyes, especially in low-light environments. This PR introduces a dark mode toggle feature, ensuring a better user experience by allowing users to switch themes seamlessly.

Related Issue

Before:

  • The website only had a light theme.
  • No option to toggle between light and dark modes.

image

After:

  • A dark mode toggle button is added to the navbar.
  • The selected theme preference is saved and applied on reload.
  • Improved accessibility and user experience.
    image

Signed-off-by: DeshDeepakKant <deshdeepakkant@gmail.com>
@kmesh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nlgwcy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Feb 1, 2025

Deploy Preview for kmesh-net ready!

Name Link
🔨 Latest commit 4f18a21
🔍 Latest deploy log https://app.netlify.com/sites/kmesh-net/deploys/679e93c53cb28d0007428982
😎 Deploy Preview https://deploy-preview-127--kmesh-net.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

# 修改背景色主题
theme = "minimal"

# Enable users to switch between day and night mode?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you did not pull in the previous updates in your branch before opening the pull request. Please do the needful 🙌

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also same request I opened before this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which pr?

@LiZhenCheng9527
Copy link
Collaborator

Sorry, but this issue has already been submitted for #121
I can't merge the same change twice. 👀
So,can you close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants