-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strong button affordance, or add a cursor pointer #12
Comments
That's been bothering me as well, just haven't had the time to fix it. I'll get into it later. |
@kmikiy Thanks! I can take a crack at it after work today -- which option are you leaning towards (better affordance vs cursor pointer)? |
With the latest version of SpotMenu (1.3) almost the whole surface is clickable, so just simply using a cursor pointer might not help that much. Better affordance might be a better option, although I don't have any ideas on how to make the buttons look more like buttons and keep a minimal design at the same time. |
I disagree re: not using a cursor pointer, I think that adding one and maybe changing the arrow to a light grey on hover would help significantly. I completely agree re: better affordance, though. That's a tough problem, especially if you're trying to be consistent with macOS styling. Which is why I think that the cursor pointer is better than nothing. :) |
@camdenb I'm confused, the article you linked strongly disagrees with using |
@TrevorSayre Yeah, a hover state or better button affordance would be ideal, but as a bare minimum a pointer is better than nothing. |
👋 Hey, thanks for the project @kmikiy! I was playing with this today and wanted to suggest a few small changes that might help here. Let me know if you agree, and I'll PR it!
|
@jacobpgn nice, looks great🙌🏻 it would be awesome if you made a PR! |
Yeah, looks amazing!! Maybe the next/previous buttons could have some extra clickable space around them to make them a little easier to click? |
For kmikiy#12 This adds: - button alpha change on hover state - more recognisable next/previous icons - smaller target areas to make it harder to hit the wrong button
This is a minor issue, but the Next/Previous track buttons should either be more clearly buttons, or the cursor should change into a pointer when hovering over them.
See: https://medium.com/simple-human/buttons-shouldnt-have-a-hand-cursor-b11e99ca374b#.s47d20e3t
The text was updated successfully, but these errors were encountered: