Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong button affordance, or add a cursor pointer #12

Open
camdenb opened this issue Feb 21, 2017 · 9 comments
Open

Strong button affordance, or add a cursor pointer #12

camdenb opened this issue Feb 21, 2017 · 9 comments

Comments

@camdenb
Copy link

camdenb commented Feb 21, 2017

This is a minor issue, but the Next/Previous track buttons should either be more clearly buttons, or the cursor should change into a pointer when hovering over them.

See: https://medium.com/simple-human/buttons-shouldnt-have-a-hand-cursor-b11e99ca374b#.s47d20e3t

@kmikiy
Copy link
Owner

kmikiy commented Feb 21, 2017

That's been bothering me as well, just haven't had the time to fix it. I'll get into it later.

@camdenb
Copy link
Author

camdenb commented Feb 21, 2017

@kmikiy Thanks! I can take a crack at it after work today -- which option are you leaning towards (better affordance vs cursor pointer)?

@kmikiy
Copy link
Owner

kmikiy commented Feb 21, 2017

With the latest version of SpotMenu (1.3) almost the whole surface is clickable, so just simply using a cursor pointer might not help that much. Better affordance might be a better option, although I don't have any ideas on how to make the buttons look more like buttons and keep a minimal design at the same time.

@camdenb
Copy link
Author

camdenb commented Feb 21, 2017

I disagree re: not using a cursor pointer, I think that adding one and maybe changing the arrow to a light grey on hover would help significantly.

I completely agree re: better affordance, though. That's a tough problem, especially if you're trying to be consistent with macOS styling. Which is why I think that the cursor pointer is better than nothing. :)

@TrevorSayre
Copy link

@camdenb I'm confused, the article you linked strongly disagrees with using cursor: pointer over buttons like the prev/next affordances in the menulet. And yet you seem to be advocating for their use. I think a hover state for the affordances would be sufficient.

@camdenb
Copy link
Author

camdenb commented Mar 20, 2017

@TrevorSayre Yeah, a hover state or better button affordance would be ideal, but as a bare minimum a pointer is better than nothing.

@jacobpgn
Copy link

jacobpgn commented Apr 7, 2018

👋 Hey, thanks for the project @kmikiy!

I was playing with this today and wanted to suggest a few small changes that might help here. Let me know if you agree, and I'll PR it!

  • button alpha change on hover state
  • more recognisable next/previous icons (hopefully without spoiling the clean/minimal look)
  • smaller target areas to make it harder to hit the wrong button

e.g.
kapture 2018-04-07 at 20 28 12

@kmikiy
Copy link
Owner

kmikiy commented Apr 7, 2018

@jacobpgn nice, looks great🙌🏻 it would be awesome if you made a PR!

@camden
Copy link

camden commented Apr 7, 2018

Yeah, looks amazing!! Maybe the next/previous buttons could have some extra clickable space around them to make them a little easier to click?

jacobpgn added a commit to jacobpgn/SpotMenu that referenced this issue Apr 8, 2018
For kmikiy#12

This adds:
- button alpha change on hover state
- more recognisable next/previous icons
- smaller target areas to make it harder to hit the wrong button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants