Skip to content

Github workflow fails for python 3.6 #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leejuyuu opened this issue May 26, 2024 · 2 comments · Fixed by #118
Closed

Github workflow fails for python 3.6 #117

leejuyuu opened this issue May 26, 2024 · 2 comments · Fixed by #118

Comments

@leejuyuu
Copy link
Contributor

This is found in #116 and was also present in #113. Because the ubuntu-latest image was updated to 22.04, which does not have any installable python 3.6 tarballs, the setup-python will fail with an error message Error: Version 3.6 with arch x64 not found. This is because python 3.6 reached EOL in 2021. See actions/setup-python#544 for more details.

We have two options to make CI work again:

  1. Test against the oldest supported (3.8) and the newest stable (3.12) releases. (See https://devguide.python.org/versions/)
  2. Pin the ubuntu test image version to 20.04.

I would suggest option 1 so people can update to the supported python versions.

@kmkurn
Copy link
Owner

kmkurn commented May 27, 2024

Thank you for tracking down this issue and providing references and potential solutions. I really appreciate it! I agree that option 1 seems best. Would you be interested in creating a PR for that? I think ideally the PR should be merged before #116.

@leejuyuu
Copy link
Contributor Author

leejuyuu commented May 27, 2024

Sure! I'm trying different version combinations. The minimum available torch for python 3.8 is 1.4.

Is there a reason to pin pytest and pytest-cov in the requirements? Pytest 3.2.5 gives some ModuleNotFound on python 3.12, so I would probably change that.

leejuyuu added a commit to leejuyuu/pytorch-crf that referenced this issue Jun 1, 2024
Because python 3.6 has reached EOL and was dropped from the
ubuntu-latest image (22.04), the CI will fail when setting up the
environment.
See kmkurn#117

This updates the python version in the CI matrix to use the oldest and
latest supported minor python verion.
The torch version is also updated to match the available build on PyPI.
leejuyuu added a commit to leejuyuu/pytorch-crf that referenced this issue Jun 2, 2024
Because python 3.6 has reached EOL and was dropped from the
ubuntu-latest image (22.04), the CI will fail when setting up the
environment.
See kmkurn#117

This updates the python version in the CI matrix to use the oldest and
latest supported minor python verion.
The torch version is also updated to match the available build on PyPI.
leejuyuu added a commit to leejuyuu/pytorch-crf that referenced this issue Jun 5, 2024
Because python 3.6 has reached EOL and was dropped from the
ubuntu-latest image (22.04), the CI will fail when setting up the
environment.
See kmkurn#117

This updates the python version in the CI matrix to use the oldest and
latest supported minor python verion.
The torch version is also updated to match the available build on PyPI.
leejuyuu added a commit to leejuyuu/pytorch-crf that referenced this issue Jun 5, 2024
Because python 3.6 has reached EOL and was dropped from the
ubuntu-latest image (22.04), the CI will fail when setting up the
environment.
See kmkurn#117

This updates the python version in the CI matrix to use the oldest
supported minor python verion.
The torch version is also updated to match the available build on PyPI.
Testing on oldest torch 2.x is also added.
kmkurn pushed a commit that referenced this issue Jun 6, 2024
Because python 3.6 has reached EOL and was dropped from the
ubuntu-latest image (22.04), the CI will fail when setting up the
environment.
See #117

This updates the python version in the CI matrix to use the oldest
supported minor python verion.
The torch version is also updated to match the available build on PyPI.
Testing on oldest torch 2.x is also added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants