Verify absolute path creation #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelikov
approved these changes
Aug 17, 2024
If a relative path is supplied, the conversion to an absolute path can fail, e.g. if current working directory does not exist anymore. Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> Link: kmod-project#79 Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
Calling free(NULL) is valid. No need for previous if-check. Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> Link: kmod-project#79 Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
lucasdemarchi
force-pushed
the
relative
branch
from
e12eae1 to
34aaf08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a relative path is supplied, the conversion to an absolute path can fail, e.g. if current working directory does not exist anymore.
Proof of Concept:
The depmod command actually processes system files, because turning
relativeinto an absolute path failed and returnedNULL.NULLin turn is interpreted as default, i.e. to use default paths.