shared: use proper data types in freadline_wrapped #81
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use signed data types if unsigned arithmetic is expected, i.e. use size_t if processing sizes and unsigned int for line numbers due to given API of freadline_wrapped. This fixes a possible signed integer overflow on 64 bit systems.
evelikov
approved these changes
Aug 21, 2024
lucasdemarchi
pushed a commit
that referenced
this pull request
Aug 22, 2024
Do not use signed data types if unsigned arithmetic is expected, i.e. use size_t if processing sizes and unsigned int for line numbers due to given API of freadline_wrapped. This fixes a possible signed integer overflow on 64 bit systems. Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com> Link: #81 Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
|
Applied, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use signed data types if unsigned arithmetic is expected, i.e. use size_t if processing sizes and unsigned int for line numbers due to given API of freadline_wrapped.
This fixes a possible signed integer overflow on 64 bit systems.
Proof of Concept:
Create a file with a line longer than 2 GB
dd if=/dev/zero bs=1024 count=2097153 | tr '\0' 'a' > /lib/modules/$(uname -r)/modules.weakdepRun lsmod compiled with -fsanitize=undefined
lsmodYou will get an error like:
shared/util.c:330:10: runtime error: signed integer overflow: 1073741824 * 2 cannot be represented in type 'int'