Set Elem() value if data is of pointer type (#536)

Signed-off-by: Masudur Rahman <masud@appscode.com>
kmodules · Jul 12, 2023 · aba17ce · aba17ce
1 parent 4f1c62e
commit aba17ce
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/client/client.go b/client/client.go
@@ -90,7 +90,8 @@ func CreateOrPatch(ctx context.Context, c client.Client, obj client.Object, tran
 		if err != nil {
 			return kutil.VerbUnchanged, err
 		}
-		reflect.ValueOf(obj).Elem().Set(reflect.ValueOf(mod))
+
+		setValue(mod, obj)
 		return kutil.VerbCreated, err
 	} else if err != nil {
 		return kutil.VerbUnchanged, err
@@ -114,10 +115,19 @@ func CreateOrPatch(ctx context.Context, c client.Client, obj client.Object, tran
 	if err != nil {
 		return kutil.VerbUnchanged, err
 	}
-	reflect.ValueOf(obj).Elem().Set(reflect.ValueOf(mod))
+
+	setValue(mod, obj)
 	return kutil.VerbPatched, nil
 }
 
+func setValue(src, target any) {
+	srcValue := reflect.ValueOf(src)
+	if srcValue.Kind() == reflect.Pointer {
+		srcValue = srcValue.Elem()
+	}
+	reflect.ValueOf(target).Elem().Set(srcValue)
+}
+
 func PatchStatus(ctx context.Context, c client.Client, obj client.Object, transform TransformStatusFunc, opts ...client.PatchOption) (client.Object, kutil.VerbType, error) {
 	key := types.NamespacedName{
 		Namespace: obj.GetNamespace(),