Use client.Reader instead of client.Client

Signed-off-by: Tamal Saha <tamal@appscode.com>
kmodules · Oct 11, 2024 · d759e6b · d759e6b
1 parent 8fc3d5e
commit d759e6b
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/cluster/ace.go b/cluster/ace.go
@@ -24,7 +24,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
-func IsACEManaged(kc client.Client) bool {
+func IsACEManaged(kc client.Reader) bool {
 	var list unstructured.UnstructuredList
 	list.SetAPIVersion("apps/v1")
 	list.SetKind("Deployment")

diff --git a/cluster/lib.go b/cluster/lib.go
@@ -157,7 +157,7 @@ func UpsertClusterMetadata(kc client.Client, md *kmapi.ClusterMetadata) error {
 	return err
 }
 
-func DetectCAPICluster(kc client.Client) (*kmapi.CAPIClusterInfo, error) {
+func DetectCAPICluster(kc client.Reader) (*kmapi.CAPIClusterInfo, error) {
 	var list unstructured.UnstructuredList
 	list.SetGroupVersionKind(schema.GroupVersionKind{
 		Group:   "cluster.x-k8s.io",

diff --git a/cluster/ocm.go b/cluster/ocm.go
@@ -35,7 +35,7 @@ func IsOpenClusterHub(mapper meta.RESTMapper) bool {
 	return false
 }
 
-func IsOpenClusterSpoke(kc client.Client) bool {
+func IsOpenClusterSpoke(kc client.Reader) bool {
 	var list unstructured.UnstructuredList
 	list.SetAPIVersion("operator.open-cluster-management.io/v1")
 	list.SetKind("Klusterlet")

diff --git a/cluster/rancher.go b/cluster/rancher.go
@@ -129,15 +129,15 @@ func isInProject(kc client.Client, nsName, seedNS string) (bool, error) {
 	return projectId == seedProjectId, nil
 }
 
-func GetDefaultProjectId(kc client.Client) (string, bool, error) {
+func GetDefaultProjectId(kc client.Reader) (string, bool, error) {
 	return GetProjectId(kc, metav1.NamespaceDefault)
 }
 
-func GetSystemProjectId(kc client.Client) (string, bool, error) {
+func GetSystemProjectId(kc client.Reader) (string, bool, error) {
 	return GetProjectId(kc, metav1.NamespaceSystem)
 }
 
-func GetProjectId(kc client.Client, nsName string) (string, bool, error) {
+func GetProjectId(kc client.Reader, nsName string) (string, bool, error) {
 	var ns core.Namespace
 	err := kc.Get(context.TODO(), client.ObjectKey{Name: nsName}, &ns)
 	if err != nil {

diff --git a/cluster/vcluster.go b/cluster/vcluster.go
@@ -24,7 +24,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
-func IsVirtualCluster(kc client.Client) (bool, error) {
+func IsVirtualCluster(kc client.Reader) (bool, error) {
 	var list core.NodeList
 	err := kc.List(context.TODO(), &list)
 	if err != nil {
@@ -44,7 +44,7 @@ func IsVirtualCluster(kc client.Client) (bool, error) {
 	return false, nil
 }
 
-func MustIsVirtualCluster(kc client.Client) bool {
+func MustIsVirtualCluster(kc client.Reader) bool {
 	ok, _ := IsVirtualCluster(kc)
 	return ok
 }