Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined control sequence: "...req@@makecaption@label@font@setting" #1350

Closed
m-shibata opened this issue Jul 29, 2019 · 1 comment
Closed

Comments

@m-shibata
Copy link
Contributor

Re:VIEW 3.2とjlreqのHEADの組み合わせでreview-jlreqを使おうとすると、
"jlreq@@makecaption@label@font@setting"がUndefined control sequenceになります。

環境:

  • Re:VIEW 3.2
  • jlreq.cls 20190507(20190401でも同様)
  • TeX Live 2018
  • Ubuntu 19.04

再現手順:

$ review-init --latex-template=review-jlreq test
$ cd test

$ cat <<EOF >test.re
= test

//cmd{
test
//}
EOF

$ rake pdf
(中略)
./test.tex:7: Undefined control sequence.
<argument> ...req@@makecaption@label@font@setting
                                                  \csname fnum@\@captype \en...
l.7 \reviewimagecaption{caption}
(後略)

原因:

  • review-base.styのifdefinedの文字列で@がひとつ余計な気がします
% 古いjlreq.clsへの互換(当面のad-hoc対応)
\ifdefined\jlreq@@makecaption@font@setting
\else
\let\jlreq@@makecaption@font@setting\jlreq@@makecaption@font
\fi
\ifdefined\jlreq@@makecaption@label@@font@setting
  % => ここの「@@font」は本来「@font」?
\else
\let\jlreq@@makecaption@label@font@setting\jlreq@@makecaption@label@font
\fi
  1. jlreq@@makecaption@label@@font@setting」は存在しない
  2. jlreq@@makecaption@label@font@setting」が「jlreq@@makecaption@label@font」で上書き
  3. 新しいjlreqだと「jlreq@@makecaption@label@font」がないのでundefinedエラー

備考:

  • jlreqの1/23の以下のコミットより前だと、上記でも問題なく成功します
  • edb9692
@m-shibata
Copy link
Contributor Author

余計なナルトを消すだけのpull requestを #1351 として作成しました。

@kmuto kmuto closed this as completed in 97e14fc Aug 11, 2019
kmuto added a commit that referenced this issue Aug 11, 2019
fix too many naruto on jlreq/review-base.sty. Closes: #1350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant