通しノンブル #1129
Closed
通しノンブル #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(print): load gentombow package at the end of review-jsbook.cls
review-jsbook.cls: gentombow対応、\includefullpagebraphics対応、ちまちまbrush-up
disabled <papersize>j, <ptsize>pt options for jsbook.cls (cameraready=ebook): fixed layout option/parameter against jsbook.cls
review-jsbook.cls: paper=<papersize>に対応
disabled <papersize>j, <ptsize>pt options for jsbook.cls (cameraready=ebook): fixed layout option/parameter against jsbook.cls
review-jsbook.cls (tombopaper,paperwidth,paperheight): supported
review-jsbook/review-base.sty (\footskip): dropped
supported \AtEndOfReVIEWMacro
… and startpage option.
|
serialpage判定は適当でいいかということでさくっと。startpageはfrontmatterにパッチするような形で設定 |
|
reviewjsbookclsブランチに取り込み済み |
|
最初のPR時点じゃないとマージ先指定はいろいろ難しいのだな…。こっちはcloseしておきます |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
review-jlreq側に実装してみていますが、オプション渡しのところがうまくいかなくて悩んでいます。
でserial_paginationドキュメントオプション値（デフォルトfalse）を取り、serial_pagination=trueなら\recls@serialpagetrueになるはず（typeoutで見てもtrueで来てはいるっぽい）。
が、このあとの
のほうで判定しようとすると、常にfalseになってしまう。何か評価順のところを間違っている？？