Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epubmaker: include cover image into metadata for iBooks #1293

Merged
merged 1 commit into from
Apr 16, 2019
Merged

epubmaker: include cover image into metadata for iBooks #1293

merged 1 commit into from
Apr 16, 2019

Conversation

kmuto
Copy link
Owner

@kmuto kmuto commented Apr 16, 2019

#1292 の代替

  • もともと epubv2 向けにcommonでopf_coverimageというのを用意していた
  • EPUBv3では表紙のmetaは不要になったはずでopfからは除去していたが、AppleのiBooksではまだこれを参照してしまう模様
  • metaがあること自体でvalidatorがエラーになることはないようなので、EPUBv3でも復活させる

@kmuto kmuto mentioned this pull request Apr 16, 2019
Closed
@kmuto kmuto merged commit 931e6f1 into master Apr 16, 2019
@kmuto kmuto deleted the coverimagemetaforv3 branch April 16, 2019 09:00
kmuto added a commit that referenced this pull request Apr 16, 2019
@kmuto
#1293
1263e12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kmuto