Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop: make Style/MethodCallWithArgsParentheses enable #1360

Merged
merged 2 commits into from
Aug 12, 2019

Conversation

takahashim
Copy link
Collaborator

cf. #1357

@kmuto
Copy link
Owner

kmuto commented Aug 12, 2019

ヒアドキュメントのところが読みにくくなりそうなので、writeは許容しようと思います。

@kmuto
Copy link
Owner

kmuto commented Aug 12, 2019

ヒアドキュメント等の読み易さとprint/putsとの整合性として、writeで引数1つの場合はカッコを省略するようにしました。

@kmuto
Copy link
Owner

kmuto commented Aug 12, 2019

マージしてほかのブランチも合わせていきますね。

@kmuto kmuto merged commit b4c3da9 into master Aug 12, 2019
@kmuto kmuto deleted the method-call-paren branch August 12, 2019 11:42
kmuto added a commit that referenced this pull request Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants