-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
キャプションの上または下を設定するcaption_positionの実装 #1361
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed
@takahashim |
Closed
方針と基本実装はこれ以上あまりどうにもならなそうに思うので、テストケースを作ります(いくつか漏れがあったので修正中)。 |
テストケースを作成し、HTML,LATEX,TEXT,IDGXMLについて期待の動作をするようにしました。 |
こちらは機能的にはマージして問題ないかと思いますが、メソッド名は変えたほうが良いかもです。 素直に実装すると |
おぉ、ご提案ありがとうございます! topは微妙だなーと思っていたので |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1320 のcaption_positionの実装です。
refactoring-headerブランチから継承しているので、前の実装よりはかなり読みやすくはなかったかと思います。
副作用として、topbuilderのimageはこれまで上キャプションでしたが、ほかのビルダ合わせで下キャプションに変わります。