Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not allow tricky id used as path; fix #1393 #1565

Merged
merged 2 commits into from
Aug 29, 2020

Conversation

takahashim
Copy link
Collaborator

path characters: A-Z + a-z + 0-9 + _:=+-()|

path characters: `A-Z` + `a-z` + `0-9` + `_:=+-()|`
@takahashim
Copy link
Collaborator Author

とりあえずきつめの制限にしてみましたが、マルチバイト文字等は許した方が良いでしょうか

@kmuto
Copy link
Owner

kmuto commented Aug 29, 2020

アタリで原稿の 図X-X のままとかにすることはあるので、警告はともかくエラーにされるのはきついですね。
実際のファイルシステムに一般に置かれる&使われるもののうちTeX的にまずいのって半角スペースくらいだという気がするので、半角スペースだけを撥ねるのがよいかなと思います。

@takahashim
Copy link
Collaborator Author

なるほど、では半角スペースのみをチェックするようにしてみます

@kmuto
Copy link
Owner

kmuto commented Aug 29, 2020

👍

@takahashim takahashim merged commit abae279 into master Aug 29, 2020
@takahashim takahashim deleted the check-tricky-id-as-path branch August 29, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants