update rubocop #1613
Merged
update rubocop #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add rubocop-rake, suggested by rubocop
takahashim
commented
Dec 19, 2020
| @@ -39,7 +39,7 @@ def inspect | |||
| # Construct Content object by passing a sequence of parameters or hash. | |||
| # Keys of +hash+ relate with each parameters. | |||
| # +file+ (or +hash+["file"]) is required. Others are optional. | |||
| def initialize(fileorhash, id = nil, media = nil, title = nil, level = nil, notoc = nil, properties = nil, chaptype = nil) | |||
| def initialize(fileorhash, id = nil, media = nil, title = nil, level = nil, notoc = nil, properties = nil, chaptype = nil) # rubocop:disable Metrics/ParameterLists | |||
There was a problem hiding this comment.
This rubocop:disable should be removed, IMO.
（EPUBMaker::Content.new()は引数をハッシュ or 名前付き引数のみにしてしまった方が良さそうです。そうすればこのコメントは消せるはず）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add rubocop-rake, suggested by rubocop